10000 fix(v2): Fix params builder to provide default transformation manager by ritigupt · Pull Request #1549 · aws-powertools/powertools-lambda-java · GitHub
[go: up one dir, main page]

Skip to content

fix(v2): Fix params builder to provide default transformation manager #1549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 24, 2024

Conversation

ritigupt
Copy link
Contributor
@ritigupt ritigupt commented Jan 5, 2024

Issue #, if available:
issue

Description of changes:

Add default transformation manager in params builders

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
sonarqubecloud bot commented Jan 5, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

4 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ritigupt ritigupt changed the title Fix params builder fix(v2): Fix params builder to provide default transformation manager Jan 5, 2024
@ritigupt1
Copy link

@scottgerring can you please review this, it is opened since long.

Copy link
Contributor
@scottgerring scottgerring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @ritigupt1

@scottgerring scottgerring merged commit 3963d6d into aws-powertools:v2 Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0