10000 fix(v2): Add default transformation manager in params module by ritigupt · Pull Request #1546 · aws-powertools/powertools-lambda-java · GitHub
[go: up one dir, main page]

Skip to content

fix(v2): Add default transformation manager in params module #1546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

ritigupt
Copy link
Contributor
@ritigupt ritigupt commented Jan 1, 2024

Issue #, if available:
issue

Description of changes:

Added default transformation Manager in ssm and secrets builder

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

jasoniharris and others added 3 commits December 5, 2023 09:33
…ools#1532)

* Setting up Kotlin environment. Converting test to Kotlin.

* Deploying via SAM successfully.

* Added Kotlin example.

* Removing unused Gradle build file.

* Adding SAM template so can be used as an existing project and Java target compatibility

* Adding SAM template so can be used as an existing project

* Updating guidance to use SAM for build and deploy

* Restructuring separate Java and Kotlin examples.

* Updating core examples readme to represent new structure for Java and Kotlin examples.

* Refactoring application code for efficiency, updating build to cover tests too and is more idiomatic and readme to be more descriptive

* Updating to fix trailing \n

* Updating guidance to be more specific for examples

* Adopting new mechanism for specifying jvm target.

* accommodating new project structure

* Fixing link typo after refactoring

* Setting up Kotlin environment. Converting test to Kotlin.

* Deploying via SAM successfully.

* Added Kotlin example.

* Removing unused Gradle build file.

* Adding SAM template so can be used as an existing project and Java target compatibility

* Adding SAM template so can be used as an existing project

* Updating guidance to use SAM for build and deploy

* Restructuring separate Java and Kotlin examples.

* Updating core examples readme to represent new structure for Java and Kotlin examples.

* Refactoring application code for efficiency, updating build to cover tests too and is more idiomatic and readme to be more descriptive

* Updating to fix trailing \n

* Updating guidance to be more specific for examples

* Adopting new mechanism for specifying jvm target.

* accommodating new project structure

* Fixing link typo after refactoring

* Flattening structure back to original to make merging easier for v2

* Adding build for Kotlin Gradle

* Adding build for Kotlin Gradle - Restructuring Java examples to v1 approach

* Correcting paths

* Adding SNAPSHOT support and local capability for Maven. Testing using Java 1.8

* Reviewed and updated against PR comments.

* Un-commenting examples

* Adding validation step for IaC SAM

* Adding Terraform for Java projects IaC validator and linter

* Adding additional projects for SAM validation and matrix approach

* Refactoring stream function to process input logging example with a Lambda Function URL instead of APIGW.

* Demonstrating Java streaming response

* Refactoring stream function to process input logging example to return

* Update CONTRIBUTING.md

* fix: get trace id from system property when env var is not set (aws-powertools#1503)

* fix: check if XRAY Trace ID is present in System property

* chore: remove erroneous extra char in tests

* fix aws-powertools#1500 (aws-powertools#1506)

* feat: Add support for POWERTOOLS_LOGGER_LOG_EVENT (aws-powertools#1510)

* chore: Addition of Warn Message If Invalid Annotation Key While Tracing aws-powertools#1511 (aws-powertools#1512)

* feat: ALC (aws-powertools#1514)

* handle AWS_LAMBDA_LOG configuration

* ALC documentation + code review

* update doc

* chore:Prep release 1.18.0 (aws-powertools#1515)

* chore:prep release 1.18.0

* update version

* update version in kotlin example

* maven local repo in gradle example

* update changelog

---------

Co-authored-by: scottgerring <scottgerring@users.noreply.github.com>

* chore: update version to next snapshot: 1-19.0-SNAPSHOT (aws-powertools#1516)

* update version to next snapshot: 1-19.0-SNAPSHOT

* update version to next snapshot: 1-19.0-SNAPSHOT

* update version to next snapshot: 1-19.0-SNAPSHOT

* building only for LTS

* Add some more margin to the test pause (aws-powertools#1518)

* test: e2e tests with java 21 (aws-powertools#1517)

* e2e tests with java 21

* Run Java21 tests using the Java17 compiler

* Run all of the E2E tests in parallel, not just the first 3

* Try again

* .

* Let's try again

* Add some comment on Java21 to the repo

* Add caveat about lambda runtimes

* Clean up wording a little

---------

Co-authored-by: Scott Gerring <gerrings@amazon.com>

* update doc for ALC (aws-powertools#1520)

* chore: Testing java21 aspectj pre-release (aws-powertools#1519)

* e2e tests with java 21

* use aspectj 1.9.21-SNAPSHOT

* Fix log4j2.xml missing in logging test for java21

* rollback double runtime

* remove comment

* keep aspectj 1.9.7 in parent for java8 compatibility

* use M1 instead of snapshot

* update documentation for aspectj

* update documentation for aspectj

---------

Co-authored-by: Jerome Van Der Linden <jeromevdl@gmail.com>

* chore: Remove build cruft

* Adding context for using RequestStreamHandler

* removing pr_lint

* Update examples/powertools-examples-core/sam/src/main/java/helloworld/AppStream.java

Clarify usage of RequestStreamHandler.

Co-authored-by: Alexey Soshin <alexey.soshin@gmail.com>

---------

Co-authored-by: Jason Harris <harrzjas@amazon.com>
Co-authored-by: Scott Gerring <scottgerring@users.noreply.github.com>
Co-authored-by: Jason Harris <harrzjas@amazon.co.uk>
Co-authored-by: Jérôme Van Der Linden <117538+jeromevdl@users.noreply.github.com>
Co-authored-by: Michele Ricciardi <mriccia@amazon.com>
Co-authored-by: Alexey Soshin <alexey.soshin@gmail.com>
Co-authored-by: jdoherty <jdoherty07@gmail.com>
Co-authored-by: Scott Gerring <gerrings@amazon.com>
Co-authored-by: Jerome Van Der Linden <jeromevdl@gmail.com>
…pproach. (aws-powertools#1533)

* SAM and Terraform IaC extracted from pr_build and simplified approach.

* Update .github/workflows/pr_iac_lint.yml

Co-authored-by: Scott Gerring <scottgerring@users.noreply.github.com>

---------

Co-authored-by: Jason Harris <harrzjas@amazon.co.uk>
Co-authored-by: Scott Gerring <scottgerring@users.noreply.github.com>
@ritigupt ritigupt changed the title Add default transformation manager in ssm and secrets builder Fix: Add default transformation manager in ssm and secrets builder Jan 1, 2024
@ritigupt ritigupt changed the title Fix: Add default transformation manager in ssm and secrets builder fix(v2): Add default transformation manager in ssm and secrets builder Jan 1, 2024
Copy link
Contributor
@jeromevdl jeromevdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it not done in DynamoDB and AppConfig ?

@pull-request-size pull-request-size bot added size/S and removed size/XS labels Jan 2, 2024
@ritigupt
Copy link
Contributor Author
ritigupt commented Jan 2, 2024

Why is it not done in DynamoDB and AppConfig ?
done.

@jeromevdl jeromevdl changed the title fix(v2): Add default transformation manager in ssm and secrets builder fix(v2): Add default transformation manager in params module Jan 2, 2024
@ritigupt ritigupt requested a review from jeromevdl January 2, 2024 14:30
* Remove CDK test

* Build core utilities so that sam validator can find them

* Remove CDK test

* Ok just build it all

* Remove the plan ...

* Remove terraform plan from iac lint

---------

Co-authored-by: Jérôme Van Der Linden <117538+jeromevdl@users.noreply.github.com>
@jeromevdl jeromevdl requested review from scottgerring and removed request for jeromevdl January 3, 2024 08:28
@scottgerring
Copy link
Contributor

Hey @ritigupt thanks for the changes!
I'd love to see some tests covering this, as we only picked up the issue as part of manually deploying and running the examples - this could be as simple as creating the parameter provider and trying to use a transformer. What do you think?

@ritigupt
Copy link
Contributor Author
ritigupt commented Jan 5, 2024

Hey @ritigupt thanks for the changes! I'd love to see some tests covering this, as we only picked up the issue as part of manually deploying and running the examples - this could be as simple as creating the parameter provider and trying to use a transformer. What do you think?

Agreed. Will add Unit tests covering these in a while.

@ritigupt ritigupt force-pushed the fix/params-ssm-secret-provider branch from 00b58da to 47fab11 Compare January 5, 2024 13:54
@pull-request-size pull-request-size bot added size/L and removed size/S labels Jan 5, 2024
Copy link
sonarqubecloud bot commented Jan 5, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@ritigupt
Copy link
Contributor Author
ritigupt commented Jan 5, 2024

@scottgerring I think I messed up something in this branch while trying to sync up this branch with my forked repo. I have opened another PR #1549, please ignore this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0