8000 Prevent overwriting existing libraries and platforms at first IDE start-up by AlbyIanna · Pull Request #1169 · arduino/arduino-ide · GitHub
[go: up one dir, main page]
Skip to content

Prevent overwriting existing libraries and platforms at first IDE start-up #1169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 15, 2022
Merged

Prevent overwriting existing libraries and platforms at first IDE start-up #1169

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
121aa67
move initialization of libs and platforms into new contribution
Jul 7, 2022
42283ba
use noOverwrite when install built-in libraries and platform
Jul 11, 2022
9236f2e
catch errors when installing platforms and libraries at first start-up
Jul 14, 2022
1b214e7
arduino-cli version 0.25.0-rc1
Jul 14, 2022
cd9719e
refine platforms and libraries initialization in case of errors
Jul 14, 2022
6c4482f
add trailing newline when libraries and platform installation fail
Jul 14, 2022
68bc78a
use regex to check error if builtin library dependencies are already …
Jul 15, 2022
28b5732
rename contribution
Jul 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
8000 Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
catch errors when installing platforms and libraries at first start-up
  • Loading branch information
Alberto Iannaccone committed Jul 14, 2022
commit 9236f2e80d34df3f967f727c7905ca4bea5bda0d
22 changes: 13 additions & 9 deletions arduino-ide-extension/src/browser/contributions/init-libs-platforms.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,17 +31,21 @@ export class InitLibsPlatforms extends Contribution {
)[0];

if (avrPackage) {
await this.boardsService.install({
item: avrPackage,
noOverwrite: true, // We don't want to automatically replace custom platforms the user might already have in place
});
try {
await this.boardsService.install({
item: avrPackage,
noOverwrite: true, // We don't want to automatically replace custom platforms the user might already have in place
});
} catch {} // If this fails, we still want to install the libraries
}
if (builtInLibrary) {
await this.libraryService.install({
item: builtInLibrary,
installDependencies: true,
noOverwrite: true, // We don't want to automatically replace custom libraries the user might already have in place
});
try {
await this.libraryService.install({
item: builtInLibrary,
installDependencies: true,
noOverwrite: true, // We don't want to automatically replace custom libraries the user might already have in place
});
} catch {}
}
}
}
Expand Down
0