8000 Prevent overwriting existing libraries and platforms at first IDE start-up by AlbyIanna · Pull Request #1169 · arduino/arduino-ide · GitHub
[go: up one dir, main page]
Skip to content

Prevent overwriting existing libraries and platforms at first IDE start-up #1169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 15, 2022
Merged

Prevent overwriting existing libraries and platforms at first IDE start-up #1169

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
121aa67
move initialization of libs and platforms into new contribution
Jul 7, 2022
42283ba
use noOverwrite when install built-in libraries and platform
Jul 11, 2022
9236f2e
catch errors when installing platforms and libraries at first start-up
Jul 14, 2022
1b214e7
arduino-cli version 0.25.0-rc1
Jul 14, 2022
cd9719e
refine platforms and libraries initialization in case of errors
Jul 14, 2022
6c4482f
add trailing newline when libraries and platform installation fail
Jul 14, 2022
68bc78a
use regex to check error if builtin library dependencies are already …
Jul 15, 2022
28b5732
rename contribution
Jul 15, 2022
File filter

Filter by extension

Filter by extension
8000
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
arduino-cli version 0.25.0-rc1
  • Loading branch information
Alberto Iannaccone committed Jul 14, 2022
commit 1b214e7db800673337b7d28ce19f35e56e94ac90
6 changes: 1 addition & 5 deletions arduino-ide-extension/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,11 +155,7 @@
],
"arduino": {
"cli": {
"version": {
"owner": "arduino",
"repo": "arduino-cli",
"commitish": "ffe4232b359fcfa87238d68acf1c3b64a1621f14"
}
"version": "0.25.0-rc1"
},
"fwuploader": {
< 8000 span class='blob-code-inner blob-code-marker ' data-code-marker=" "> "version": "2.2.0"
Expand Down
4 changes: 4 additions & 0 deletions arduino-ide-extension/src/node/cli-protocol/cc/arduino/cli/commands/v1/compile_pb.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,9 @@ export class CompileRequest extends jspb.Message {
getEncryptKey(): string;
setEncryptKey(value: string): CompileRequest;

getSkipLibrariesDiscovery(): boolean;
setSkipLibrariesDiscovery(value: boolean): CompileRequest;


serializeBinary(): Uint8Array;
toObject(includeInstance?: boolean): CompileRequest.AsObject;
Expand Down Expand Up @@ -133,6 +136,7 @@ export namespace CompileRequest {
keysKeychain: string,
signKey: string,
encryptKey: string,
skipLibrariesDiscovery: boolean,
}
}

Expand Down
32 changes: 31 additions & 1 deletion arduino-ide-extension/src/node/cli-protocol/cc/arduino/cli/commands/v1/compile_pb.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,8 @@ proto.cc.arduino.cli.commands.v1.CompileRequest.toObject = function(includeInsta
libraryList: (f = jspb.Message.getRepeatedField(msg, 24)) == null ? undefined : f,
keysKeychain: jspb.Message.getFieldWithDefault(msg, 25, ""),
signKey: jspb.Message.getFieldWithDefault(msg, 26, ""),
encryptKey: jspb.Message.getFieldWithDefault(msg, 27, "")
encryptKey: jspb.Message.getFieldWithDefault(msg, 27, ""),
skipLibrariesDiscovery: jspb.Message.getBooleanFieldWithDefault(msg, 28, false)
};

if (includeInstance) {
Expand Down Expand Up @@ -286,6 +287,10 @@ proto.cc.arduino.cli.commands.v1.CompileRequest.deserializeBinaryFromReader = fu
var value = /** @type {string} */ (reader.readString());
msg.setEncryptKey(value);
break;
case 28:
var value = /** @type {boolean} */ (reader.readBool());
msg.setSkipLibrariesDiscovery(value);
break;
default:
reader.skipField();
break;
Expand Down Expand Up @@ -482,6 +487,13 @@ proto.cc.arduino.cli.commands.v1.CompileRequest.serializeBinaryToWriter = functi
f
);
}
f = message.getSkipLibrariesDiscovery();
if (f) {
writer.writeBool(
28,
f
);
}
};


Expand Down Expand Up @@ -1016,6 +1028,24 @@ proto.cc.arduino.cli.commands.v1.CompileRequest.prototype.setEncryptKey = functi
};


/**
* optional bool skip_libraries_discovery = 28;
* @return {boolean}
*/
proto.cc.arduino.cli.commands.v1.CompileRequest.prototype.getSkipLibrariesDiscovery = function() {
return /** @type {boolean} */ (jspb.Message.getBooleanFieldWithDefault(this, 28, false));
};


/**
* @param {boolean} value
* @return {!proto.cc.arduino.cli.commands.v1.CompileRequest} returns this
*/
proto.cc.arduino.cli.commands.v1.CompileRequest.prototype.setSkipLibrariesDiscovery = function(value) {
return jspb.Message.setProto3BooleanField(this, 28, value);
};



/**
* List of repeated fields within this message type.
Expand Down
0