This repository was archived by the owner on Dec 13, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 57
Start up server HTTP interface earlier #994
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 tasks
neunhoef
approved these changes
May 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. One typo suggested to correct.
Co-authored-by: Max Neunhöffer <max@arangodb.com>
Simran-B
previously requested changes
May 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The last bullet point needs to be adjusted accordingly:
https://github.com/arangodb/docs/blob/feature/open-http-interface-earlier/3.10/http/general.md#error-handling
Co-authored-by: Simran <Simran-B@users.noreply.github.com>
Co-authored-by: Simran <Simran-B@users.noreply.github.com>
Co-authored-by: Simran <Simran-B@users.noreply.github.com>
@Simran-B This is included upstream arangodb/arangodb#16181 |
@joerg84 I'm not sure what you try to say. This PR is blocked by arangodb/arangodb#16381 as indicated by the updated description. |
…22-06-29T09:14:37+00:00
ansoboleva
approved these changes
Jun 29, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream PRs:
TODO: