Start up server HTTP interface earlier #16181
8000
Jump to bottom
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Start up HTTP interface of servers earlier, so that ping probes from tools can already be responded to when the server is not fully started. Previously, the HTTP interface of a server was only openend after a successful recovery procedure, but the recovery procedure can take time proportional to the amount of data to recover. In order to make servers respond to probes quickly after a restart, the HTTP interface is now opened earlier in the startup sequence. When a server is not through the successful recovery procedure yet, it will respond to _all_ requests with an HTTP response code 503 and an "errorNum" value of 503 as well, so that callers can see that the server is not fully ready.
neunhoef
approved these changes
Apr 28, 2022
There was a problem hiding this comment.
Provisionally, this look good to me. I have to look a bit more closely tomorrow, for example, I would like to inspect the feature dependency graph in this branch to see where the GeneralServerFeature now sits. But all in all, this looks good. We should now talk to Adam to find out what information we should deliver in what way during the startup.
| @@ -129,6 +129,8 @@ std::shared_ptr<RestHandler> RestHandlerFactory::createHandler( | |||
|
|
|||
| void RestHandlerFactory::addHandler(std::string const& path, create_fptr func, | |||
| void* data) { | |||
| WRITE_LOCKER(locker, _lock); | |||
There was a problem hiding this comment.
Oh je, war das ungeschützter Verkehr?
There was a problem hiding this comment.
It was fine before, because previously we added all handlers before the HTTP interface was opened.
So no other thread could concurrently access the list of handlers.
…n-http-interface-earlier
…n-http-interface-earlier
…n-http-interface-earlier
…n-http-interface-earlier
…n-http-interface-earlier
…n-http-interface-earlier
…n-http-interface-earlier
…n-http-interface-earlier
…n-http-interface-earlier
…godb/arangodb into feature/open-http-interface-earlier
…n-http-interface-earlier
…n-http-interface-earlier
…n-http-interface-earlier
…n-http-interface-earlier
…n-http-interface-earlier
3 tasks
…n-http-interface-earlier
…n-http-interface-earlier
neunhoef
approved these changes
May 19, 2022
…n-http-interface-earlier
…n-http-interface-earlier
ansoboleva
added a commit
to arangodb/docs
that referenced
this pull request
Jun 29, 2022
* docs PR for arangodb/arangodb#16181 * Update 3.10/release-notes-api-changes310.md Co-authored-by: Max Neunhöffer <max@arangodb.com> * Update general.md * adding suggested change to 3.10/release-notes-api-changes310.md Co-authored-by: Simran <Simran-B@users.noreply.github.com> * adding suggested change to 3.10/release-notes-api-changes310.md Co-authored-by: Simran <Simran-B@users.noreply.github.com> * adding suggested changes to 3.10/release-notes-api-changes310.md Co-authored-by: Simran <Simran-B@users.noreply.github.com> * Review, shorten release notes * Remove JSF_ prefix from DocuBlock name * moved detailed description to the main doc * removed duplicated info from the release notes * Update release-notes-api-changes310.md * Update examples for 3.10 in feature/open-http-interface-earlier at 2022-06-29T09:14:37+00:00 Co-authored-by: Max Neunhöffer <max@arangodb.com> Co-authored-by: ansoboleva <93702078+ansoboleva@users.noreply.github.com> Co-authored-by: Simran <Simran-B@users.noreply.github.com> Co-authored-by: Simran Spiller <simran@arangodb.com> Co-authored-by: arangodb-release-bot <anastasia.soboleva@arangodb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope & Purpose
Docs PR: arangodb/docs#994
Enterprise companion PR: https://github.com/arangodb/enterprise/pull/931
from tools can already be responded to when the server is not fully started.
By default, the HTTP interface is opened at the same point during the startup
sequence as before, but it can optionally be opened earlier by setting the
new startup option
--server.early-connectionstotrue. This willopen the HTTP interface early in the startup, so that the server can respond
to a limited set of REST APIs even during recovery. This can be useful
because the recovery procedure can take time proportional to the amount of
data to recover.
When the
--server.early-connectionsoption is set totrue, theserver will respond to requests to the following APIs during the startup
already:
/_api/version/_admin/version/_admin/statusAll other APIs will be responded to with an HTTP response code 503, so that
callers can see that the server is not fully ready.
If authentication is used, then only JWT authentication can be used during
the early startup phase. Incoming requests relying on other authentication
mechanisms that require access to the database data will also be responded to
with HTTP 503 errors, even if correct credentials are used.
The API
/_admin/statusnow also returns aprogressattribute that shows the server's current state (starting, stopping, etc.), with details about which feature is currently started, stopped. If the server spends a long time in the WAL recovery, the current WAL recovery sequence number is also reported in a sub-attribute. Clients can query the attribute to track the progress of the WAL recovery.Checklist
Related Information