8000 Enforce stricter transaction limits by graetzer · Pull Request #9740 · arangodb/arangodb · GitHub
[go: up one dir, main page]
Skip to content

Enforce stricter transaction limits #9740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 20, 2019
Merged

Enforce stricter transaction limits #9740

merged 7 commits into from
Aug 20, 2019

Conversation

graetzer
Copy link
Contributor

Scope & Purpose

Add transaction limitations for stream transactions

  • Strictly new functionality (i.e. a new feature / new option, no need for porting)
  • The behavior change can be verified via automatic tests

Testing & Verification

This PR adds tests that were used to verify all changes:

  • Added new integration tests (i.e. in shell_server / shell_server_aql)

http://jenkins01.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr/5748/

@graetzer graetzer added this to the devel milestone Aug 19, 2019
@graetzer graetzer requested a review from jsteemann August 19, 2019 09:19
jsteemann
jsteemann approved these changes Aug 19, 2019
View reviewed changes
arangod/Transaction/Manager.h Outdated
static constexpr size_t numBuckets = 16;
static constexpr double idleTTL = 10.0; // 10 seconds
static constexpr double totalTTL = 60.0; // 60 seconds
static constexpr double totalTTLDBServer = 3 * 60.0; // 6 minutes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the code and the comment disagree here. If it's 6 minutes, then the code should be 6 * 60.0. If 3 minutes, then the comment should be adjusted.

jsteemann
jsteemann reviewed Aug 19, 2019
View reviewed changes
arangod/Transaction/Manager.h Outdated
static constexpr double tombstoneTTL = 5.0 * 60.0; // 5 minutes

static constexpr double idleTTL = 10.0; // 10 seconds
static constexpr double idleTTLDBServer = 3 * 60.0; // 6 minutes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment or code still wrong.

graetzer and others added 2 commits August 19, 2019 16:27
@graetzer @jsteemann
Update arangod/Transaction/Manager.cpp
edf3cb4 
Co-Authored-By: Jan <jsteemann@users.noreply.github.com>
@graetzer
Update Manager.h
f6ae769
@jsteemann
Copy link
Contributor

http://jenkins01.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr/5767/

@jsteemann
Copy link
Contributor

https://jenkins01.arangodb.biz/view/PR/job/arangodb-matrix-pr/5774/

@jsteemann
Copy link
Contributor

http://jenkins01.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr/5775/

@jsteemann jsteemann merged commit f88e5b5 into devel Aug 20, 2019
graetzer added a commit that referenced this pull request Aug 20, 2019
@graetzer
Enforce stricter transaction limits (#9740)
6235acb
graetzer added a commit that referenced this pull request Aug 20, 2019
@graetzer
Enforce stricter transaction limits (#9740)
5d3736a
KVS85 pushed a commit that referenced this pull request Aug 21, 2019
@graetzer @KVS85
Enforce stricter transaction limits (#9740) (#9775)
bd5df4d 
* Enforce stricter transaction limits (#9740)

* changelog

* make CHANGELOG entry more verbose
ObiWahn added a commit that referenced this pull request Aug 22, 2019
@ObiWahn
Merge branch 'devel' of https://github.com/arangodb/arangodb into fea…
12d698d 
…ture/mimalloc

* 'devel' of https://github.com/arangodb/arangodb: (83 commits)
  Bug fix/internal issue #622 (#9781)
  mark AQL functions FULLTEXT, NEAR, WITHIN, WITHIN_RECTANGLE as cacheable (#9771)
  reduce wait timeout, use move
  Bug fix/implement windows maintenance tests (#9763)
  show query string length and cacheability in explain output (#9767)
  fix potential spurious wakeups in scheduler code (#9770)
  Bug fix/issue #9612 (#9764)
  downgrade WARN messages to INFO level (#9761)
  slightly reorder boolean members to reduce struct sizes (#9762)
  make index selection more deterministic (#9735)
  Update PULL_REQUEST_TEMPLATE.md (#9758)
  [devel] Move Shard Bug 4567124 (#9746)
  Bug fix/fix signed int overflow (#9717)
  Bug fix/fix invalid cast (#9755)
  Enforce stricter transaction limits (#9740)
  Check scheduler queue return value (#9754)
  dont fill cache on truncate (#9721)
  fix pasting from the documentation (#9742)
  tell that procdump is gone - it seems this happenes in reality without coredumps being written (#9748)
  issue #9654: make `--rocksdb.max-write-buffer-number` work (#9750)
  ...
ObiWahn added a commit that referenced this pull request Aug 23, 2019
@ObiWahn
Merge branch 'devel' of https://github.com/arangodb/arangodb into fea…
d2db845 
…ture/one-shard-db

* 'devel' of https://github.com/arangodb/arangodb: (53 commits)
  remove 404-ed callbacks from agency (#9709)
  AQL date functions improvements (#9714)
  Bug fix/internal issue #622 (#9781)
  mark AQL functions FULLTEXT, NEAR, WITHIN, WITHIN_RECTANGLE as cacheable (#9771)
  reduce wait timeout, use move
  Bug fix/implement windows maintenance tests (#9763)
  show query string length and cacheability in explain output (#9767)
  fix potential spurious wakeups in scheduler code (#9770)
  Bug fix/issue #9612 (#9764)
  downgrade WARN messages to INFO level (#9761)
  slightly reorder boolean members to reduce struct sizes (#9762)
  make index selection more deterministic (#9735)
  Update PULL_REQUEST_TEMPLATE.md (#9758)
  [devel] Move Shard Bug 4567124 (#9746)
  Bug fix/fix signed int overflow (#9717)
  Bug fix/fix invalid cast (#9755)
  Enforce stricter transaction limits (#9740)
  Check scheduler queue return value (#9754)
  dont fill cache on truncate (#9721)
  fix pasting from the documentation (#9742)
  ...
@fceller fceller deleted the feature/trx-limits branch September 6, 2019 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsteemann jsteemann jsteemann approved these changes

@ifcologne ifcologne ifcologne left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
devel
Development

Successfully merging this pull request may close these issues.
3 participants
@graetzer @jsteemann @ifcologne
0