-
Notifications
You must be signed in to change notification settings - Fork 855
Enforce stricter transaction limits #9740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you a 10000 ccount related emails.
Already on GitHub? Sign in to your account
Conversation
arangod/Transaction/Manager.h
Outdated
static constexpr size_t numBuckets = 16; | ||
static constexpr double idleTTL = 10.0; // 10 seconds | ||
static constexpr double totalTTL = 60.0; // 60 seconds | ||
static constexpr double totalTTLDBServer = 3 * 60.0; // 6 minutes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the code and the comment disagree here. If it's 6 minutes, then the code should be 6 * 60.0
. If 3 minutes, then the comment should be adjusted.
arangod/Transaction/Manager.h
Outdated
static constexpr double tombstoneTTL = 5.0 * 60.0; // 5 minutes | ||
|
||
static constexpr double idleTTL = 10.0; // 10 seconds | ||
static constexpr double idleTTLDBServer = 3 * 60.0; // 6 minutes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment or code still wrong.
Co-Authored-By: Jan <jsteemann@users.noreply.github.com>
…ture/mimalloc * 'devel' of https://github.com/arangodb/arangodb: (83 commits) Bug fix/internal issue #622 (#9781) mark AQL functions FULLTEXT, NEAR, WITHIN, WITHIN_RECTANGLE as cacheable (#9771) reduce wait timeout, use move Bug fix/implement windows maintenance tests (#9763) show query string length and cacheability in explain output (#9767) fix potential spurious wakeups in scheduler code (#9770) Bug fix/issue #9612 (#9764) downgrade WARN messages to INFO level (#9761) slightly reorder boolean members to reduce struct sizes (#9762) make index selection more deterministic (#9735) Update PULL_REQUEST_TEMPLATE.md (#9758) [devel] Move Shard Bug 4567124 (#9746) Bug fix/fix signed int overflow (#9717) Bug fix/fix invalid cast (#9755) Enforce stricter transaction limits (#9740) Check scheduler queue return value (#9754) dont fill cache on truncate (#9721) fix pasting from the documentation (#9742) tell that procdump is gone - it seems this happenes in reality without coredumps being written (#9748) issue #9654: make `--rocksdb.max-write-buffer-number` work (#9750) ...
…ture/one-shard-db * 'devel' of https://github.com/arangodb/arangodb: (53 commits) remove 404-ed callbacks from agency (#9709) AQL date functions improvements (#9714) Bug fix/internal issue #622 (#9781) mark AQL functions FULLTEXT, NEAR, WITHIN, WITHIN_RECTANGLE as cacheable (#9771) reduce wait timeout, use move Bug fix/implement windows maintenance tests (#9763) show query string length and cacheability in explain output (#9767) fix potential spurious wakeups in scheduler code (#9770) Bug fix/issue #9612 (#9764) downgrade WARN messages to INFO level (#9761) slightly reorder boolean members to reduce struct sizes (#9762) make index selection more deterministic (#9735) Update PULL_REQUEST_TEMPLATE.md (#9758) [devel] Move Shard Bug 4567124 (#9746) Bug fix/fix signed int overflow (#9717) Bug fix/fix invalid cast (#9755) Enforce stricter transaction limits (#9740) Check scheduler queue return value (#9754) dont fill cache on truncate (#9721) fix pasting from the documentation (#9742) ...
Scope & Purpose
Add transaction limitations for stream transactions
Testing & Verification
This PR adds tests that were used to verify all changes:
http://jenkins01.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr/5748/