8000 remove 404-ed callbacks from agency by kvahed · Pull Request #9709 · arangodb/arangodb · GitHub
[go: up one dir, main page]
Skip to content

remove 404-ed callbacks from agency #9709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Aug 23, 2019
Merged

remove 404-ed callbacks from agency #9709

merged 15 commits into from
Aug 23, 2019

Conversation

kvahed
Copy link
Contributor
@kvahed kvahed commented Aug 14, 2019

No description provided.

@kvahed kvahed requested a review from neunhoef August 14, 2019 09:51
@kvahed kvahed self-assigned this Aug 14, 2019
@kvahed
Copy link
Contributor Author
kvahed commented Aug 15, 2019 •
edited
Loading

https://jenkins.arangodb.biz/view/PR/job/arangodb-matrix-pr/5708/
http://chaos1.arangodb.org:4200/

neunhoef
neunhoef approved these changes Aug 20, 2019
View reviewed changes
Copy link
Member
@neunhoef neunhoef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please check if arangosync or kube-arangodb rely on the data sent out with the callbacks.

@neunhoef
Copy link
Member

Unfortunately, the API is published, so we cannot leave out the changed entries, please revert.

@kvahed
Copy link
Contributor Author
kvahed commented Aug 21, 2019

https://jenkins01.arangodb.biz/view/PR/job/arangodb-matrix-pr/5817/

@kvahed
Copy link
Contributor Author
kvahed commented Aug 21, 2019

https://jenkins01.arangodb.biz/view/PR/job/arangodb-matrix-pr/5825/

@neunhoef neunhoef merged commit 737dac3 into devel Aug 23, 2019
@neunhoef neunhoef deleted the bug-fix/cleanup-agency-callbacks branch August 23, 2019 08:13
ObiWahn added a commit that referenced this pull request Aug 23, 2019
@ObiWahn
Merge branch 'devel' of https://github.com/arangodb/arangodb into fea…
d2db845 
…ture/one-shard-db

* 'devel' of https://github.com/arangodb/arangodb: (53 commits)
  remove 404-ed callbacks from agency (#9709)
  AQL date functions improvements (#9714)
  Bug fix/internal issue #622 (#9781)
  mark AQL functions FULLTEXT, NEAR, WITHIN, WITHIN_RECTANGLE as cacheable (#9771)
  reduce wait timeout, use move
  Bug fix/implement windows maintenance tests (#9763)
  show query string length and cacheability in explain output (#9767)
  fix potential spurious wakeups in scheduler code (#9770)
  Bug fix/issue #9612 (#9764)
  downgrade WARN messages to INFO level (#9761)
  slightly reorder boolean members to reduce struct sizes (#9762)
  make index selection more deterministic (#9735)
  Update PULL_REQUEST_TEMPLATE.md (#9758)
  [devel] Move Shard Bug 4567124 (#9746)
  Bug fix/fix signed int overflow (#9717)
  Bug fix/fix invalid cast (#9755)
  Enforce stricter transaction limits (#9740)
  Check scheduler queue return value (#9754)
  dont fill cache on truncate (#9721)
  fix pasting from the documentation (#9742)
  ...
ObiWahn added a commit that referenced this pull request Aug 24, 2019
@ObiWahn
Merge branch 'devel' of https://github.com/arangodb/arangodb into fea…
781b54a 
…ture/intermediate-commit-stats

* 'devel' of https://github.com/arangodb/arangodb:
  Add user restrictions for streaming transactions. (#9793)
  remove 404-ed callbacks from agency (#9709)
  AQL date functions improvements (#9714)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neunhoef neunhoef neunhoef approved these changes

Assignees

@kvahed kvahed

Labels
9 WIP Team Clifton
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kvahed @neunhoef
0