Fix potential segfault #9308
Merged
Fix potential segfault #9308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goedderz
approved these changes
Jun 24, 2019
1442bb3 to
f3d37cc
Compare
f3d37cc to
ddcc27b
Compare
|
Rebased, de-conflicted, and another jenkins here: https://jenkins01.arangodb.biz/view/PR/job/arangodb-matrix-pr/7301/ |
ObiWahn
added a commit
that referenced
this pull request
Nov 21, 2019
…ture/dump-db-properties * 'devel' of https://github.com/arangodb/arangodb: Splicing gather cleanup (#10479) Feature/changelog for subquery splicing (#10396) Fix potential segfault (#9308) don't smile away exception fixing issue #10470 (#10491) add generated front end files in order to allow collection creation Added precondition to ensure that server is still as seen before. (#10468) Actually use the given format to execute a query (#10484) Fix SubqueryStartExecutor (#10488) add tests for inventory (#10464) fix truncate operation in synchronous replication (#10492)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope & Purpose
Check whether
nameis empty when resolving collection name before we access it.While we're here, use
isdigitinstead of check whether character is between0and9.This might relate to the crash seen in #9302 (comment) but is hard to verify.
Related Information
(Please reference tickets / specification etc )
Testing & Verification
I do not know whether there is a simple way to test these functions, in particular how an empty collection name can get through.