8000 Actually use the given format to execute a query by mchacki · Pull Request #10484 · arangodb/arangodb · GitHub
[go: up one dir, main page]
Skip to content

Actually use the given format to execute a query #10484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 21, 2019
Merged

Actually use the given format to execute a query #10484

merged 2 commits into from
Nov 21, 2019

Conversation

mchacki
Copy link
Member
@mchacki mchacki commented Nov 20, 2019

This fixes a rolling upgrade issue 3.5.* -> devel

During upgrade the AQL should be performed in 3.5 format, this has not been forwarded correctly inside the DBServers.

Jenkins:
http://jenkins01.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr/7282/

@mchacki mchacki added the 1 Bug label Nov 20, 2019
@mchacki mchacki added this to the devel milestone Nov 20, 2019
@mchacki 8000 mchacki requested review from hkernbach and goedderz November 20, 2019 12:16
@mchacki mchacki self-assigned this Nov 20, 2019
hkernbach
hkernbach requested changes Nov 20, 2019
View reviewed changes
Copy link
Member
@hkernbach hkernbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One minor change requested. Will test this in our rolling upgrade procedure, then will approve.

goedderz
goedderz approved these changes Nov 20, 2019
View reviewed changes
Copy link
Member
@goedderz goedderz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hkernbach
Copy link
Member

Upgade passed:

2019-11-20T13:59:01Z [20398] INFO executing upgrade procedure: disabling server features
2019-11-20T13:59:01Z [20398] INFO [43396] {authentication} Jwt secret not specified, generating...
2019-11-20T13:59:02Z [20398] INFO [144fe] using storage engine 'rocksdb'
2019-11-20T13:59:02Z [20398] INFO [a1c60] {syscall} file-descriptors (nofiles) hard limit is unlimited, soft limit is 8192
2019-11-20T13:59:02Z [20398] INFO [3844e] {authentication} Authentication is turned off, authentication for unix sockets is turned on
2019-11-20T13:59:02Z [20398] INFO [0de5e] database upgrade passed
2019-11-20T13:59:02Z [20398] INFO [7da27] {startup} server will now shut down due to upgrade, database initialization or admin restoration.

Startup passed:

2019-11-20T13:59:11Z [20434] INFO [e52b0] ArangoDB 3.6.0-devel [darwin] 64bit maintainer mode, using build heads/bug-fix/rolling-upgrade-aql-block-serialization-0-g5fd37e3c5b, VPack 0.1.33, RocksDB 6.2.0, ICU 58.1, V8 7.1.302.28, OpenSSL 1.1.1d  10 Sep 2019
2019-11-20T13:59:11Z [20434] WARNING [0458b] This is a maintainer version intended for debugging. DO NOT USE IN PRODUCTION!
2019-11-20T13:59:11Z [20434] WARNING [bd666] ==============================================================================
2019-11-20T13:59:11Z [20434] INFO [43396] {authentication} Jwt secret not specified, generating...
2019-11-20T13:59:11Z [20434] INFO [144fe] using storage engine 'rocksdb'
2019-11-20T13:59:11Z [20434] INFO [3bb7d] {cluster} Starting up with role PRIMARY
2019-11-20T13:59:11Z [20434] INFO [6ea38] using endpoint 'http+tcp://[::]:8540' for non-encrypted requests
2019-11-20T13:59:11Z [20434] INFO [a1c60] {syscall} file-descriptors (nofiles) hard limit is unlimited, soft limit is 8192
2019-11-20T13:59:11Z [20434] INFO [3844e] {authentication} Authentication is turned off, authentication for unix sockets is turned on
2019-11-20T13:59:11Z [20434] INFO [b6826] {cluster} Cluster feature is turned on. Agency version: {"server":"arango","license":"enterprise","version":"3.5.1"}, Agency endpoints: http+tcp://127.0.0.1:8531, http+tcp://127.0.0.1:8541, http+tcp://127.0.0.1:8551, server id: 'PRMR-a70cff21-6124-4910-b39d-c6dcac5f64b6', internal endpoint / address: tcp://localhost:8540', advertised endpoint: , role: 2
2019-11-20T13:59:11Z [20434] INFO [805b2] {cluster} using heartbeat interval value '1000 ms' from agency
2019-11-20T13:59:11Z [20434] INFO [cf3f4] ArangoDB (version 3.6.0-devel [darwin]) is ready for business. Have fun!

@hkernbach
Copy link
Member

BUT, coordinator fails to start.

@mchacki
Copy link
Member Author
mchacki commented Nov 20, 2019

Fixed the error reported by HKernbach

New jenkins
http://jenkins01.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr/7300/

Please rereview

goedderz
goedderz approved these changes Nov 20, 2019
View reviewed changes
Copy link
Member
@goedderz goedderz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mchacki mchacki merged commit 3090e49 into devel Nov 21, 2019
@mchacki mchacki deleted the bug-fix/rolling-upgrade-aql-block-serialization branch November 21, 2019 08:10
ObiWahn added a commit that referenced this pull request Nov 21, 2019
@ObiWahn
Merge branch 'devel' of https://github.com/arangodb/arangodb into fea…
fdde83d 
…ture/dump-db-properties

* 'devel' of https://github.com/arangodb/arangodb:
  Splicing gather cleanup (#10479)
  Feature/changelog for subquery splicing (#10396)
  Fix potential segfault (#9308)
  don't smile away exception
  fixing issue #10470 (#10491)
  add generated front end files in order to allow collection creation
  Added precondition to ensure that server is still as seen before. (#10468)
  Actually use the given format to execute a query (#10484)
  Fix SubqueryStartExecutor (#10488)
  add tests for inventory (#10464)
  fix truncate operation in synchronous replication (#10492)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goedderz goedderz goedderz approved these changes

@hkernbach hkernbach Awaiting requested review from hkernbach

Assignees

@mchacki mchacki

Labels
1 Bug
Projects
None yet
Milestone
devel
Development

Successfully merging this pull request may close these issues.
3 participants
@mchacki @hkernbach @goedderz
0