8000 Allow addEdge() to take vertex ids in the JS library by moonglum · Pull Request #651 · arangodb/arangodb · GitHub
[go: up one dir, main page]
Skip to content

Allow addEdge() to take vertex ids in the JS library #651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 31, 2013
Merged

Allow addEdge() to take vertex ids in the JS library #651

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e7e47ce
Graph Module / Client: It has to send the ID, not the key
Oct 31, 2013
d9a14a8
Code Style
Oct 31, 2013
1c2b379
Graph Refactoring: Determination of ID pushed to Common
Oct 31, 2013
3ddbe6b
Graph Module: Alternatively provide ID instead of Vertex in addEdge
Oct 31, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Code Style
  • Loading branch information
moonglum committed Oct 31, 2013
commit d9a14a8f165783b281a3f802bd8a0f7a1b878ca4
6 changes: 5 additions & 1 deletion js/common/modules/org/arangodb/graph-common.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -728,7 +728,11 @@ Graph.prototype.getOrAddVertex = function (id) {
////////////////////////////////////////////////////////////////////////////////

Graph.prototype.addEdge = function (out_vertex, in_vertex, id, label, data, waitForSync) {
return this._saveEdge(id, out_vertex, in_vertex, this._prepareEdgeData(data, label), waitForSync);
return this._saveEdge(id,
out_vertex,
in_vertex,
this._prepareEdgeData(data, label),
waitForSync);
};

////////////////////////////////////////////////////////////////////////////////
Expand Down
6 changes: 3 additions & 3 deletions js/server/modules/org/arangodb/graph.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -571,9 +571,9 @@ Graph.prototype._saveEdge = function(id, out_vertex, in_vertex, shallow, waitFor
}

var ref = this._edges.save(out_vertex._properties._id,
in_vertex._properties._id,
shallow,
waitForSync);
in_vertex._properties._id,
shallow,
waitForSync);

return this.constructEdge(ref._id);
};
Expand Down
0