More visibility to catch a sleeper #21774
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goedderz
reviewed
May 19, 2025
There was a problem hiding this comment.
I think all log messages here should also print the block info and query id, like you added for [62514] already. This makes it possibly to connect multiple distinct log messages, which can also be on different threads, and see whether they belong to the same query and block or not.
Co-authored-by: Tobias Gödderz <tobias@arangodb.com>
goedderz
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For our hunt of a sleeper we add further diagnosis:
PrefetchTask::waitForgets a loop with a timeout andmore logging if the timeout occurs.
thread concurrently w.r.t.
execute()and the destructor.concurrently.
This is a forward-port from 3.12.4-4 to 3.12.5, original PR:
#21742
Scope & Purpose
Checklist