8000 More visibility to catch a sleeper by neunhoef · Pull Request #21774 · arangodb/arangodb · GitHub
[go: up one dir, main page]
Skip to content

More visibility to catch a sleeper #21774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
May 20, 2025
Merged

More visibility to catch a sleeper #21774

merged 12 commits into from
May 20, 2025

Conversation

neunhoef
Copy link
Member

For our hunt of a sleeper we add further diagnosis:

  1. The PrefetchTask::waitFor gets a loop with a timeout and
    more logging if the timeout occurs.
  2. We detect, if an ExecutionBlock is used by more than one
    thread concurrently w.r.t. execute() and the destructor.
  3. We detect, if more than one thread is waiting for a PrefetchTask
    concurrently.

This is a forward-port from 3.12.4-4 to 3.12.5, original PR:

#21742

Scope & Purpose

  • [*] Visibility

Checklist

  • [*] 📖 CHANGELOG entry made

@neunhoef neunhoef added this to the devel milestone May 19, 2025
@neunhoef neunhoef self-assigned this May 19, 2025
@cla-bot cla-bot bot added the cla-signed label May 19, 2025
goedderz
goedderz reviewed May 19, 2025
View reviewed changes
Copy link
Member
@goedderz goedderz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think all log messages here should also print the block info and query id, like you added for [62514] already. This makes it possibly to connect multiple distinct log messages, which can also be on different threads, and see whether they belong to the same query and block or not.

@neunhoef neunhoef merged commit 989275f into devel May 20, 2025
7 checks passed
@neunhoef neunhoef deleted the visibility/hunt-for-sleeper branch May 20, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goedderz goedderz goedderz approved these changes

Assignees

@neunhoef neunhoef

Labels
cla-signed
Projects
None yet
Milestone
devel
Development

Successfully merging this pull request may close these issues.
2 participants
@neunhoef @goedderz
0