Forward port for: print on violated block ordering (#21743) #21773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added printing for violation of shutdown ordering * Exclude GatherNodes from order violation checks. Added more informative printing * Applied review comment. Also added ALERT. Also print if we are still starting async tasks although we already stopped them --------- Co-authored-by: Max Neunhoeffer <max@arangodb.com>
goedderz
reviewed
May 19, 2025
Comment on lines
+1058
to
+1076
| bool hasStoppedAsyncTasks = block->hasStoppedAsyncTasks(); | ||
| if (hasStoppedAsyncTasks) { | ||
| LOG_TOPIC("14d22", WARN, Logger::AQL) | ||
| << "[query#" << block->getQuery().id() << "] ALERT" | ||
| << block->printBlockInfo() | ||
| << " was asked to stop async task. We still start one. " | ||
| "This is an allowed rare race."; | ||
| } | ||
|
|
||
| auto stopGuard = | ||
| ScopeGuard([block, hasStoppedAsyncTasks]() noexcept { | ||
| if (hasStoppedAsyncTasks) { | ||
| LOG_TOPIC("14d21", WARN, Logger::AQL) | ||
| << "[query#" << block->getQuery().id() | ||
| << "] CLEAR ALERT" << block->printBlockInfo() | ||
| << " We completed the task of the aforementioned " | ||
| "race. All is fine."; | ||
| } | ||
| }); |
There was a problem hiding this comment.
These should not be on WARN, but probably on DEBUG.
There was a problem hiding this comment.
If they are DEBUG, then we do not see them in production, or?
goedderz
reviewed
May 19, 2025
Comment on lines
+292
to
+295
| LOG_TOPIC("a6c2b", WARN, Logger::AQL) | ||
| << "ALERT Stopping async tasks for " << block->printBlockInfo() | ||
| << " but have already stopped dependency " | ||
| << seenDependency->printBlockInfo(); |
There was a problem hiding this comment.
I think this could actually be bumped to ERROR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope & Purpose
This PR adds more visibility into a violated assumptions. The cleanup of AQL expects Blocks to be in a particular order in the cleanup lists. This PR should add visibility in cases where it is unexpectedly not.
Checklist
Related Information
(Please reference tickets / specification / other PRs etc)