Bug fix/print on violated block ordering #21743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goedderz
reviewed
Apr 30, 2025
arangod/Aql/ExecutionEngine.cpp
Outdated
Comment on lines
295
to
297
| for (auto it2 = _blocks.rbegin(); it2 != _blocks.rend(); ++it2) { | ||
| LOG_TOPIC("a6c2d", WARN, Logger::AQL) << (*it2)->printBlockAndDependenciesInfo(); | ||
| } |
There was a problem hiding this comment.
Maybe print this only once, even if multiple blocks violate the assumption?
| // We have a dependency that has already been seen, we need to log this | ||
| // situation in theory this could lead to deadlocks. Some Blocks are | ||
| // fine we just want to see those here. | ||
| // Gather Nodes are known to violate this, but they are safe. |
10000
There was a problem hiding this comment.
Should we not do the warning for gather nodes then, to not spam the log with warnings?
There was a problem hiding this comment.
I would like to point you to the following line:
seenDependency != nullptr && block->getPlanNode()->getType() != ExecutionNode::GATHER) {
;)
…starting async tasks although we already stopped them
* sleeping barber in SharedQueryState * double entry in change log * Add oskar branch parameter to CircleCI * disable vector index on ARM for now, faiss is known to be crashy now. (#21718) * disable vector index on ARM for now, faiss is known to be crashy now. * lint * lint * disable on ARM * disable on ARM --------- Co-authored-by: Vadim Kondratev <vadim@arangodb.com> Co-authored-by: Wilfried Goesgens <willi@arangodb.com>
…olated-block-ordering
mchacki
added a commit
that referenced
this pull request
May 19, 2025
* Added printing for violation of shutdown ordering * Exclude GatherNodes from order violation checks. Added more informative printing * Applied review comment. Also added ALERT. Also print if we are still starting async tasks although we already stopped them --------- Co-authored-by: Max Neunhoeffer <max@arangodb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope & Purpose
This PR adds. more visibility into a violated assumptions. The cleanup of AQL expects Blocks to be in a particular order in the cleanup lists. This PR should add visibility in cases where it is unexpectedly not.
Checklist
Related Information
(Please reference tickets / specification / other PRs etc)