8000 [PREGEL] Split Graph.h, make PregelShard its own struct by markuspf · Pull Request #17963 · arangodb/arangodb · GitHub
[go: up one dir, main page]
Skip to content

[PREGEL] Split Graph.h, make PregelShard its own struct #17963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Feb 6, 2023
Merged

[PREGEL] Split Graph.h, make PregelShard its own struct #17963

merged 12 commits into from
Feb 6, 2023

Conversation

markuspf
Copy link
Contributor

Scope & Purpose

  • Split Graph.h into Vertex.h, VertexID.h, Edge.h, and PregelShard.h so there is one type per header; this is to facilitate the changes coming to the GraphStore in a forthcoming PR
  • Make PregelShard a proper type, not just a typedef; this should facilitate the change to making the VertexIDs in Pregel fixed size later.
  • Add some small tests for PregelShard

Note that is is based off of #17922

@markuspf markuspf added the 3 Pregel Graph processing label Jan 17, 2023
@markuspf markuspf added this to the devel milestone Jan 17, 2023
@markuspf markuspf requested review from jvolmer and a team January 17, 2023 15:16
@cla-bot cla-bot bot added the cla-signed label Jan 17, 2023
Base automatically changed from chore/pregel-test-executable to devel January 17, 2023 16:41
jvolmer
jvolmer approved these changes Jan 18, 2023
View reviewed changes
Copy link
Contributor
@jvolmer jvolmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markuspf markuspf force-pushed the chore/pregel-graph-store-part-1 branch 4 times, most recently from e31b54c to 9fe397d Compare January 26, 2023 10:29
@markuspf markuspf force-pushed the chore/pregel-graph-store-part-1 branch from 9fe397d to 74f1190 Compare January 27, 2023 16:24
@markuspf markuspf force-pushed the chore/pregel-graph-store-part-1 branch from 74f1190 to cd2c776 Compare February 6, 2023 08:54
@markuspf markuspf force-pushed the chore/pregel-graph-store-part-1 br 8EF7 anch from 523e3b3 to 03ee368 Compare February 6, 2023 14:16
@markuspf markuspf merged commit 2abee2f into devel Feb 6, 2023
@markuspf markuspf deleted the chore/pregel-graph-store-part-1 branch February 6, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvolmer jvolmer jvolmer approved these changes

Assignees
No one assigned
Labels
3 Pregel Graph processing cla-signed
Projects
None yet
Milestone
devel
Development

Successfully merging this pull request may close these issues.
2 participants
@markuspf @jvolmer
0