[PREGEL] Provide test binary for Pregel #17922
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvolmer
approved these changes
Jan 12, 2023
| ${PROJECT_SOURCE_DIR}/arangod | ||
| ${PROJECT_SOURCE_DIR}/lib) | ||
|
|
||
| target_link_libraries(arango_tests_pregel |
There was a problem hiding this comment.
I think you can make the linking of all these targets PRIVATE to not spill the public API of arango_tests_pregel
90f7c54 to
61893d1
Compare
37e590b to
b193761
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope & Purpose
Adds
CMakeLists.txtfortests/Pregel, which adds a test executablearangodbtests_pregeland a test casepregel;Note that
typedbuffer.cppis not included in this test-binary intentionally because of its large dependency footprint and the fact that we plan to remove that class. It is still tested byarangodbtests.