[3.9] Restrict hybrid disjoint sg directions for Path Queries #16333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r is stored in a different number type.
…ybrid-disjoint-sg-directions
jsteemann
reviewed
Jun 3, 2022
10000
jsteemann
reviewed
Jun 3, 2022
jsteemann
reviewed
Jun 3, 2022
jsteemann
reviewed
Jun 3, 2022
jsteemann
reviewed
Jun 3, 2022
| @@ -202,20 +253,27 @@ GraphNode::GraphNode(ExecutionPlan* plan, ExecutionNodeId id, | |||
| THROW_ARANGO_EXCEPTION_MESSAGE(TRI_ERROR_ARANGO_COLLECTION_TYPE_INVALID, | |||
There was a problem hiding this comment.
The error message could be misleading if the collection cannot be found. Then we should rather return TRI_ERROR_ARANGO_DATA_SOURCE_NOT_FOUND and an appropriate message.
But I don't insist on making this change.
There was a problem hiding this comment.
I agree on this change.
However I think this independent of this PR (code here is old)
Will create followup pr for this.
jsteemann
reviewed
Jun 3, 2022
hkernbach
approved these changes
Jun 3, 2022
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
jsteemann
approved these changes
Jun 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope & Purpose
Backport of #16214
This PR hits the enterprise version only.
For Hybrid Disjoint SmartGraphs we decided to restrict switches between Smart and Satellite
for a single AQL Node to at most one switch.
So every Graph node that switches two (or more) times will cause the query to reject.
Note: This is a breaking change! there can be queries that do not work anymore.
However original behavior especially for path queries, delivered undefined results.
Please see Enterprise PR for technical details.
Checklist
Related Information
(Please reference tickets / specification / other PRs etc)