Restrict hybrid disjoint sg directions #16214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… if a SmartDisjoint query is violating edge conditions
…rid-disjoint-sg-directions
…rid-disjoint-sg-directions
…n satellite collections we will get multiple responses from different servers.
…distribute them properly.
…sjoint-sg-directions
goedderz
reviewed
May 3, 2022
goedderz
approved these changes
May 5, 2022
…sjoint-sg-directions
…sjoint-sg-directions
mchacki
added a commit
that referenced
this pull request
May 25, 2022
19 tasks
KVS85
added a commit
that referenced
this pull request
Jun 7, 2022
* Restrict hybrid disjoint sg directions (#16214) * Make VPack assertion more relaxed, it should not trigger if the number is stored in a different number type. * Added generated files * CLang formated generated files * Apply suggestions from code review Co-authored-by: Jan <jsteemann@users.noreply.github.com> * Applied review requests * Update CHANGELOG Co-authored-by: Jan <jsteemann@users.noreply.github.com> Co-authored-by: Vadim <vadim@arangodb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope & Purpose
This PR hits the enterprise version only.
For Hybrid Disjoint SmartGraphs we decided to restrict switches between Smart and Satellite
for a single AQL Node to at most one switch.
So every Graph node that switches two (or more) times will cause the query to reject.
Note: This is a breaking change! there can be queries that do not work anymore.
However original behavior especially for path queries, delivered undefined results.
Please see Enterprise PR for technical details.
Checklist
Related Information
(Please reference tickets / specification / other PRs etc)