8000 Fix BTS-548 array index wrong optimization by neunhoef · Pull Request #14780 · arangodb/arangodb · GitHub
[go: up one dir, main page]
Skip to content

Fix BTS-548 array index wrong optimization #14780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 22, 2021
Merged

Fix BTS-548 array index wrong optimization #14780

merged 8 commits into from
Sep 22, 2021

Conversation

neunhoef
Copy link
Member

This fixes BTS-548, see details there. Longer story short: if there is an array index and there is a document update or replace, then we had a shortcut which bypasses the array index update if none of the indexed attributes has changed. In the array
case the change of an array to an empty array was not recognized and thus the index was not updated.

  • Fix attributesEqual for update/replace array index changes.
  • CHANGELOG.

Scope & Purpose

(Please describe the changes in this PR for reviewers - mandatory)

[*] Bugfix (requires CHANGELOG entry)
[*] CHANGELOG entry made

Backports:

No backports required
[*] Backports required for: 3.7, 3.8

Related Information

(Please reference tickets / specification / other PRs etc)

[*] GitHub issue / Jira ticket number: BTS-548

Testing & Verification

(Please pick either of the following options)

[*] The behavior in this PR was manually tested
[*] This PR adds tests that were used to verify all changes:

    [*] Added new integration tests (e.g. in shell_server / shell_server_aql)

@neunhoef neunhoef added this to the 3.8 milestone Sep 15, 2021
@neunhoef neunhoef self-assigned this Sep 15, 2021
@neunhoef neunhoef requested a review from jsteemann September 15, 2021 14:46
@Simran-B Simran-B mentioned this pull request Sep 15, 2021
Closed
jsteemann
jsteemann reviewed Sep 15, 2021
View reviewed changes
Copy link
Contributor
@jsteemann jsteemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@KVS85 KVS85 added the 3 Optimizer AQL query optimizer is involved label Sep 20, 2021
@KVS85 KVS85 merged commit 104dfdc into 3.8 Sep 22, 2021
@KVS85 KVS85 deleted the bug-fix-3.8/array-index-wrong-optimization branch September 22, 2021 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsteemann jsteemann jsteemann left review comments

Assignees

@neunhoef neunhoef

Labels
3 Optimizer AQL query optimizer is involved
Projects
None yet
Milestone
3.8
Development

Successfully merging this pull request may close these issues.
4 participants
@neunhoef @jsteemann @KVS85 @goedderz
0