8000 properly rename test file by jsteemann · Pull Request #14705 · arangodb/arangodb · GitHub
[go: up one dir, main page]

Skip to content

properly rename test file #14705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2021
Merged

properly rename test file #14705

merged 1 commit into from
Aug 26, 2021

Conversation

jsteemann
Copy link
Contributor

Scope & Purpose

Properly rename a test file from -nocluster to -noncluster to prevent it from being run in cluster.
This change only affects tests. The tests in the file in question are not reliable in cluster, so they must not be run in cluster environments.

  • 💩 Bugfix (requires CHANGELOG entry)

Backports:

  • Backports required for: 3.7

Testing & Verification

  • This change is a trivial rework / code cleanup without any test coverage.
  • The behavior in this PR was manually tested

@jsteemann jsteemann added this to the 3.8 milestone Aug 26, 2021
@jsteemann jsteemann requested review from KVS85, neunhoef and cpjulia and removed request for neunhoef August 26, 2021 11:57
Copy link
Contributor
@KVS85 KVS85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@KVS85 KVS85 merged commit 24bc4c2 into 3.8 Aug 26, 2021
@KVS85 KVS85 deleted the bug-fix-3.8/rename-test-file branch August 26, 2021 13:45
@KVS85 KVS85 restored the bug-fix-3.8/rename-test-file branch September 1, 2021 10:47
@KVS85 KVS85 deleted the bug-fix-3.8/rename-test-file branch September 3, 2021 17:01
KVS85 added a commit that referenced this pull request Sep 3, 2021
* [3.8] Lower priority of AQL lanes (#14699)

* Lower priority of AQL lanes

* Added CHANGELOG entry

* Improved comments

Co-authored-by: Vadim <vadim@arangodb.com>

* added a test for statistics behavior (#14703)

* properly rename test file (#14705)

* Fix a rare shut
8000
down race in RocksDBShaCalculatorThread

* added assertion as suggested

* Update CHANGELOG

Co-authored-by: Tobias Gödderz <tobias@arangodb.com>
Co-authored-by: Vadim <vadim@arangodb.com>
KVS85 added a commit that referenced this pull request Sep 3, 2021
* [3.8] Lower priority of AQL lanes (#14699)

* Lower priority of AQL lanes

* Added CHANGELOG entry

* Improved comments

Co-authored-by: Vadim <vadim@arangodb.com>

* added a test for statistics behavior (#14703)

* properly rename test file (#14705)

* fix + test

* Update CHANGELOG

* fix build

* Update CHANGELOG

Co-authored-by: Tobias Gödderz <tobias@arangodb.com>
Co-authored-by: Vadim <vadim@arangodb.com>
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
KVS85 added a commit that referenced this pull request Sep 3, 2021
…4722) (#14724)

* [3.8] Lower priority of AQL lanes (#14699)

* Lower priority of AQL lanes

* Added CHANGELOG entry

* Improved comments

Co-authored-by: Vadim <vadim@arangodb.com>

* added a test for statistics behavior (#14703)

* properly rename test file (#14705)

* Bug fix/search 238 late materialization with constrained heap (#14722)

* add test for view case

* find a better place for sort

* fix formatting

* add index case test

* moar tests

* temporary relaxed assertion

* Update CHANGELOG

Co-authored-by: Tobias Gödderz <tobias@arangodb.com>
Co-authored-by: Vadim <vadim@arangodb.com>
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
KVS85 added a commit that referenced this pull request Sep 7, 2021
* [3.8] Lower priority of AQL lanes (#14699)

* Lower priority of AQL lanes

* Added CHANGELOG entry

* Improved comments

Co-authored-by: Vadim <vadim@arangodb.com>

* added a test for statistics behavior (#14703)

* properly rename test file (#14705)

* protoype for forceOneShardAttributeValue

* only enable restrictedShards in case one shard rule got active

* fixed getResponsibleShards usage

* do not check single boolean twice  :)

* changelog

* Update CHANGELOG

* Update CHANGELOG

Co-authored-by: Tobias Gödderz <tobias@arangodb.com>
Co-authored-by: Vadim <vadim@arangodb.com>
Co-authored-by: Heiko Kernbach <heiko@arangodb.com>
KVS85 added a commit that referenced this pull request Sep 9, 2021
* [3.8] Lower priority of AQL lanes (#14699)

* Lower priority of AQL lanes

* Added CHANGELOG entry

* Improved comments

Co-authored-by: Vadim <vadim@arangodb.com>

* added a test for statistics behavior (#14703)

* properly rename test file (#14705)

* workaround for assertion failure

* added WAL printing helper function

* update PR

Co-authored-by: Tobias Gödderz <tobias@arangodb.com>
Co-authored-by: Vadim <vadim@arangodb.com>
KVS85 added a commit that referenced this pull request Sep 11, 2021
* [3.8] Lower priority of AQL lanes (#14699)

* Lower priority of AQL lanes

* Added CHANGELOG entry

* Improved comments

Co-authored-by: Vadim <vadim@arangodb.com>

* added a test for statistics behavior (#14703)

* properly rename test file (#14705)

* fix hard time limits on move shard and cleanout server

* cleaner

* allow for long supervision job runtimes

* revert unfug in change log

* fix 412 response

* fix 412 response

* Result constructors

* integration tests

* integration tests

* integration tests

* integration tests cleanout server

* cleanoutserver integration tests

* fixing test

* 3.8 cleanout server abort -> moveshard failed

* same error over?

* Update CHANGELOG

Co-authored-by: Tobias Gödderz <tobias@arangodb.com>
Co-authored-by: Vadim <vadim@arangodb.com>
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
KVS85 added a commit that referenced this pull request Sep 14, 2021
)

* [3.8] Lower priority of AQL lanes (#14699)

* Lower priority of AQL lanes

* Added CHANGELOG entry

* Improved comments

Co-authored-by: Vadim <vadim@arangodb.com>

* added a test for statistics behavior (#14703)

* properly rename test file (#14705)

* Refactor rocks db transaction state and rocks db methods (#14543)

* make iterator usage safer after intermediate commits

Co-authored-by: mpoeter <manuel@arangodb.com>

* Fix build

* Fix handling of old subqueries

* Attempt to fix chaos load tests.

* Fix assertion

* Revert last two commits.

* Next attempt to fix chaos load tests.

* Fix: truncate must not trigger intermediate commits in streaming trx.

* Update chaos-load tests

* fix method signature

* fix test compilation

* Update CHANGELOG

* Revert unintended changes.

* Update arangod/RocksDBEngine/RocksDBTransactionMethods.cpp

Co-authored-by: Tobias Gödderz <tobias@arangodb.com>
Co-authored-by: Vadim <vadim@arangodb.com>
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
joerg84 pushed a commit that referenced this pull request Sep 20, 2021
* [3.8] Lower priority of AQL lanes (#14699)

* Lower priority of AQL lanes

* Added CHANGELOG entry

* Improved comments

Co-authored-by: Vadim <vadim@arangodb.com>

* added a test for statistics behavior (#14703)

* properly rename test file (#14705)

* Remove sendRequestRetry in health check API to contact agents.

Co-authored-by: Tobias Gödderz <tobias@arangodb.com>
Co-authored-by: Va
95C9
dim <vadim@arangodb.com>
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
KVS85 added a commit that referenced this pull request Sep 22, 2021
* [3.8] Lower priority of AQL lanes (#14699)

* Lower priority of AQL lanes

* Added CHANGELOG entry

* Improved comments

Co-authored-by: Vadim <vadim@arangodb.com>

* added a test for statistics behavior (#14703)

* properly rename test file (#14705)

* Backport fix to 3.8.

* Strange merge artifact rectified.

Co-authored-by: Tobias Gödderz <tobias@arangodb.com>
Co-authored-by: Vadim <vadim@arangodb.com>
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0