8000 Bug fix 3.8/fix typed analyzer pooling by Dronplane · Pull Request #14715 · arangodb/arangodb · GitHub
[go: up one dir, main page]
Skip to content

Bug fix 3.8/fix typed analyzer pooling #14715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 3, 2021
Merged

Bug fix 3.8/fix typed analyzer pooling #14715

merged 8 commits into from
Sep 3, 2021

Conversation

Dronplane
Copy link
Contributor

Scope & Purpose

Fix storing of TypedAnalyzer pointer in FieldIterator. Raw pointer allowed analyzer to be returned to the pool. So if several clients are concurrently inserting data - resets could land into the same analyzer instance and give invalid results to the clients

  • 💩 Bugfix (requires CHANGELOG entry)
  • 🍕 New feature (requires CHANGELOG entry, feature documentation and release notes)
  • 🔥 Performance improvement
  • 🔨 Refactoring/simplification
  • 📖 CHANGELOG entry made

goedderz and others added 5 commits August 26, 2021 16:44
@goedderz @KVS85
[3.8] Lower priority of AQL lanes (#14699)
b6eb49d 
* Lower priority of AQL lanes

* Added CHANGELOG entry

* Improved comments

Co-authored-by: Vadim <vadim@arangodb.com>
@jsteemann
added a test for statistics behavior (#14703)
fc248f7
@jsteemann
properly rename test file (#14705)
24bc4c2
@Dronplane
fix + test
c44559c
@Dronplane
Update CHANGELOG
ef9360d
@Dronplane Dronplane requested review from gnusi and KVS85 August 30, 2021 15:16
@Dronplane Dronplane self-assigned this Aug 30, 2021
@Dronplane
Copy link
Contributor Author

Tests blue except known failure in

Test "shell_client_3"
    [FAILED]  tests/js/client/shell/shell-transaction-dropped-followers-cluster.js

      "testTransactionWritesSameFollower" failed: Error: at assertion #51: assertEqual: (13) is not equal to (1)

@KVS85 KVS85 added the 3 ArangoSearch Views label Sep 3, 2021
KVS85
KVS85 approved these changes Sep 3, 2021
View reviewed changes
Copy link
Contributor
@KVS85 KVS85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@KVS85 KVS85 merged commit c8b0aba into 3.8 Sep 3, 2021
@KVS85 KVS85 deleted the bug-fix-3.8/fix-typed-analyzer-pooling branch September 3, 2021 17:15
@KVS85 KVS85 added this to the 3.8 milestone Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnusi gnusi gnusi approved these changes

@KVS85 KVS85 KVS85 approved these changes

Assignees

@Dronplane Dronplane

Labels
3 ArangoSearch Views
Projects
None yet
Milestone
3.8
Development

Successfully merging this pull request may close these issues.
5 participants
@Dronplane @gnusi @KVS85 @goedderz @jsteemann
0