Satellite-Graphs / Broken Sorted Gather #11340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r with satellite collections.
jsteemann
reviewed
Mar 27, 2020
arangod/Aql/OptimizerRules.cpp
Outdated
| opt->addPlan(std::move(plan), rule, modified); | ||
| } | ||
|
|
||
| void arangodb::aql::decayUnnecessarySortedGather(Optimizer* opt, std::unique_ptr<ExecutionPlan> plan, |
Contributor
There was a problem hiding this comment.
we normally indent with just 2 spaces. why is it all different here?
jsteemann
reviewed
Mar 27, 2020
jsteemann
approved these changes
Mar 27, 2020
goedderz
requested changes
Mar 27, 2020
Member
There was a problem hiding this comment.
Please have a look at my comment on GatherNode::findCollection. Everything else LGTM.
tests/js/server/aql/aql-optimizer-rule-decay-unnecessary-sorted-gather.js
Outdated
Show resolved
Hide resolved
|
|
||
| testNonEnterprise: function () { | ||
| // this query has to be that complicated, because | ||
| // 1. if we only use a single collection with repl fact 1, the one shard rule will apply |
Member
There was a problem hiding this comment.
You could just disable the cluster-one-shard rule.
| testNonEnterprise: function () { | ||
| // this query has to be that complicated, because | ||
| // 1. if we only use a single collection with repl fact 1, the one shard rule will apply | ||
| // 2. the FILTER forces the sharded collection to enumerated first |
Member
There was a problem hiding this comment.
You could disable the interchange-adjacent-enumeration rule, which I suppose switched the enumerations.
Contributor
Author
Contributor
Author
Contributor
Author
added 2 commits
April 1, 2020 09:49
… origin/feature/satellite-graphs-2-decy-sorted-gather
goedderz
reviewed
Apr 9, 2020
added 2 commits
April 9, 2020 10:19
… origin/feature/satellite-graphs-2-decy-sorted-gather
Contributor
Author
…odb/arangodb into origin/feature/satellite-graphs-2-decy-sorted-gather
…odb/arangodb into origin/feature/satellite-graphs-2-decy-sorted-gather
8000
Member
…b/ArangoDB into origin/feature/satellite-graphs-2-decy-sorted-gather
Member
|
Jenkins blue besides known issue: |
mchacki
added a commit
that referenced
this pull request
Apr 21, 2020
* Added changelog entry stub * Added dump/restore tests for satellite graphs (#11278) * Feature/satellite graphs move singletons to dbserver (#11284) * Fixed optimizer rules order, so singletons will be moved onto the DBServer after satellite graphs are scattered * Reordered satellite optimizer rules * added a missing check for replicationFactor equals satellite (string) (#11307) * Parallel Gather Satellite Graphs (#11315) * Parallel gather when using satellite traversals. * Feature/satellite graphs extend graphsuite k shortest path (#11300) * add weightAttribute support to our TestGraph environment * added distances values to graphs * added multiple shortest path tests to proto graphs * added first k shortest path example to graph test suite * fixed an assert, more testcases * added smallCircle k shortest path tests * added completeGraph k shortest path tests * more cleanup, added bug in shortestpath check method, new tests * one more k shortest for complete graph * added k shortest path tests for easypath graph * added k shortest path tests for advancedpath graph * added k shortest path weight tests for advancedpath graph * Small changes and clean up. * Fixed tests for kShortestPaths to correctly test lengths. * clean up. * Fixed one test and clean up. Co-authored-by: lamai93 <lars@arangodb.com> * Exported isSatelliteNode and isUsedAsSatellite. (#11343) * Feature/satellite graphs 2 modification creation tests (#11332) * graph initial check, added new error * collection graph check * added parameter * formatting, changed a methods signature * applied new signature * cleanup, removed not needed functions, moved back to private * applied new signature * cleanup, re-added const * removed not needed method * cleanup * compile again * cleanup * cleanup, added rule, added error * only add vertex if not already found in edges * rm log * extended test * only do if needed * comment * Feature/satellite graphs 2 default values overhaul (#11382) * added default server settings struct * added new file to cmakelist * added server defaults to create graph api * new api * removed unused include * compile community * Bug fix/headers cleanup (#11391) * Bug fix/debug rocksdb mapping error (#11386) * simplify register planning code, a bit (#11385) * Add Cluster/ServerDefaults.cpp to CMakeLists.txt Co-authored-by: Jan <jsteemann@users.noreply.github.com> Co-authored-by: Markus Pfeiffer <markus@arangodb.com> * Update CHANGELOG * Fixed compile error through merge conflict * Fix traversal test for k-shortest-paths * remove merge fallout * Fix merge fallout * Merge fallout fixup * Satellite-Graphs / Broken Sorted Gather (#11340) * Added new optmizer rule to fix broken sorted gather when used together with satellite collections. * Test for smart joins. * Formatting. * Added indexes to the inspected list. * Cluster only tests. * Fix jslint. * Fixed graph nodes. * Handled more node types and improved assertions Co-authored-by: Tobias Gödderz <tobias@arangodb.com> Co-authored-by: Michael Hackstein <michael@arangodb.com> * Added waitForSatellite to IndexExecutor. (#11362) * Added waitForSatellite to IndexExecutor. * waitForSatellite for all graph nodes if required. * Move waitForSatellite to createBlock. * Merge fallout fixup and some moving code * Merge crud. * Community fix Co-authored-by: Markus Pfeiffer <markus@arangodb.com> Co-authored-by: Heiko <hkernbach@users.noreply.github.com> Co-authored-by: lamai93 <lars@arangodb.com> Co-authored-by: hkernbach <heiko.kernbach@gmail.com> Co-authored-by: Markus Pfeiffer <markus@arangodb.com> Co-authored-by: Jan <jsteemann@users.noreply.github.com> Co-authored-by: Simran <Simran-B@users.noreply.github.com> Co-authored-by: Michael Hackstein <michael@arangodb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new optmizer rule to fix broken sorted gather when used together with satellite collections.