don't use c++ 20 macros, they don't work reliably.

arangodb · jsteemann · Mar 13, 2020 · Feb 18, 2020 · Feb 19, 2020 · Feb 19, 2020
commit 219d1880a726aa7e62205f600d2dc7d50241d5d8
diff --git a/arangosh/Shell/V8ClientConnection.cpp b/arangosh/Shell/V8ClientConnection.cpp
@@ -23,10 +23,7 @@
 ////////////////////////////////////////////////////////////////////////////////
 
 #include <chrono> // make sure we have this!
-#ifndef __cpp_lib_chrono
-// this macro is a c++20 feature... 
-#define __cpp_lib_chrono 1
-#endif
+#define arangodb_have_cpp_lib_chrono 1
 #include "V8ClientConnection.h"
 
 #include <boost/algorithm/string.hpp>

diff --git a/lib/V8/v8-utils.cpp b/lib/V8/v8-utils.cpp
@@ -22,10 +22,7 @@
 ////////////////////////////////////////////////////////////////////////////////
 
 #include <chrono>
-#ifndef __cpp_lib_chrono
-// this macro is a c++20 feature... 
-#define __cpp_lib_chrono 1
-#endif
+#define arangodb_have_cpp_lib_chrono 1
 
 #include "v8-utils.h"
 

diff --git a/lib/V8/v8-utils.h b/lib/V8/v8-utils.h
@@ -110,7 +110,7 @@ void setConnectionToBeDeadInMS(uint64_t timeout);
 bool isConnectionToBeDead(v8::FunctionCallbackInfo<v8::Value> const& args);
 double getMaxTimeoutConnectionToBeDeadS(double timeoutSeconds);
 // You will only see this function if you #include <chrono>
-#ifdef __cpp_lib_chrono
+#ifdef arangodb_have_cpp_lib_chrono
 std::chrono::milliseconds getMaxTimeoutConnectionToBeDead(std::chrono::milliseconds timeout);
 #endif