Bug fix/tests cleanup #11028
Merged
Bug fix/tests cleanup #11028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tests blue |
graetzer
reviewed
Jan 31, 2020
| @@ -42,6 +42,10 @@ | |||
|
|
|||
| using namespace arangodb; | |||
| using namespace arangodb::aql; | |||
|
|
|||
| namespace { | |||
| std::vector<size_t> const emptyAttributePositions; | |||
There was a problem hiding this comment.
is this supposed to be thread_local
There was a problem hiding this comment.
The vector is only used to be passed into the DocumentProducingContext, where a const reference to it is stored. The data in the vector is never modified by the DocumentProducingContext, nor is it modified by EnumerateCollectionExecutor(Infos).
Thus it can be static and const.
dothebart
approved these changes
Jan 31, 2020
ObiWahn
added a commit
that referenced
this pull request
Feb 10, 2020
* origin/devel: feature/upgrade v8 once more (#10978) Bug fix/tests cleanup (#11028) create collections aware of server cleaning (#11008) Feature/improve ternary operator evaluation (#10634) Bug fix/deprecate mmfiles engine (#10994) attempt to ungreylist test (#11036) disable warning about `--server.jwt-secret` (#11037)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope & Purpose
Make http_replication tests always clean up the collections they create
http://172.16.10.101:8080/view/PR/job/arangodb-matrix-pr/8355/