8000 Bug fix/deprecate mmfiles engine by jsteemann · Pull Request #10994 · arangodb/arangodb · GitHub
[go: up one dir, main page]
Skip to content

Bug fix/deprecate mmfiles engine #10994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Feb 3, 2020
Merged

Bug fix/deprecate mmfiles engine #10994

merged 19 commits into from
Feb 3, 2020

Conversation

jsteemann
Copy link
Contributor
@jsteemann jsteemann commented Jan 27, 2020 •
edited
Loading

Scope & Purpose

  • Deprecate MMFiles engine and its startup options
  • Introduce startup option --server.allow-deprecated-storage-engine, which controls whether a deprecated storage engine (i.e. MMFiles) can be used for new deployments. This defaults to false, so new deployments cannot use MMFiles. We override this for our testing.

There may be tests outside of the PR matrix that fail because they attempt to start the server with the MMFiles storage engine. In case they do, arangod will abort the startup unless these tests start arangod with the extra --server.allow-deprecated-storage-engine true option.

  • Strictly new functionality (i.e. a new feature / new option, no need for porting)
  • The behavior change can be verified via automatic tests

Related Information

Testing & Verification

This change is already covered by existing tests, such as all, with `--storageEngine mmfiles.

http://172.16.10.101:8080/view/PR/job/arangodb-matrix-pr/8286/

@jsteemann jsteemann added this to the 3.7 milestone Jan 27, 2020
@jsteemann
Copy link
Contributor Author

http://172.16.10.101:8080/view/PR/job/arangodb-matrix-pr/8292/

@jsteemann jsteemann mentioned this pull request Jan 29, 2020
Merged
@jsteemann
Copy link
Contributor Author

http://172.16.10.101:8080/view/PR/job/arangodb-matrix-pr/8346/

@jsteemann
Copy link
Contributor Author

http://172.16.10.101:8080/view/PR/job/arangodb-matrix-pr/8375/

@jsteemann
Copy link
Contributor Author

Tests blue

goedderz
goedderz approved these changes Jan 31, 2020
View reviewed changes
Copy link
Member
@goedderz goedderz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsteemann jsteemann merged commit 22bad42 into devel Feb 3, 2020
@jsteemann jsteemann deleted the bug-fix/deprecate-mmfiles-engine branch February 3, 2020 09:23
@Simran-B Simran-B mentioned this pull request Feb 3, 2020
Closed
ObiWahn added a commit that referenced this pull request Feb 10, 2020
@ObiWahn
Merge remote-tracking branch 'origin/devel' into feature/validation
a9be81f 
* origin/devel:
  feature/upgrade v8 once more (#10978)
  Bug fix/tests cleanup (#11028)
  create collections aware of server cleaning (#11008)
  Feature/improve ternary operator evaluation (#10634)
  Bug fix/deprecate mmfiles engine (#10994)
  attempt to ungreylist test (#11036)
  disable warning about `--server.jwt-secret` (#11037)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graetzer graetzer graetzer approved these changes

@goedderz goedderz goedderz approved these changes

@dothebart dothebart Awaiting requested review from dothebart

@KVS85 KVS85 Awaiting requested review from KVS85

Assignees
No one assigned
Labels
9 Ready to Merge
Projects
None yet
Milestone
3.7
Development

Successfully merging this pull request may close these issues.
3 participants
@jsteemann @graetzer @goedderz
0