10000 Bug fix 3.4/disallow subqueries in prune by jsteemann · Pull Request #10266 · arangodb/arangodb · GitHub
[go: up one dir, main page]
Skip to content

Bug fix 3.4/disallow subqueries in prune #10266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 16, 2019
Merged

Bug fix 3.4/disallow subqueries in prune #10266

merged 2 commits into from
Oct 16, 2019

Conversation

jsteemann
Copy link
Contributor

Scope & Purpose

Disallow the usage of subqueries in AQL traversal PRUNE conditions, as they caused undefined behavior.

  • Bug-Fix for devel-branch (i.e. no need for backports?)
  • Bug-Fix for a released version (did you remember to port this to all relevant release branches?)
  • The behavior in this PR can be (and was) manually tested (support / qa / customers can test it)
  • The behavior change can be verified via automatic tests

Testing & Verification

This PR adds tests that were used to verify all changes:

  • Added new integration tests (i.e. in shell_server / shell_server_aql)

https://172.16.10.101/view/PR/job/arangodb-matrix-pr/6766/

@jsteemann jsteemann added this to the 3.4 milestone Oct 16, 2019
@jsteemann jsteemann requested review from KVS85 and goedderz October 16, 2019 12:10
goedderz
goedderz approved these changes Oct 16, 2019
View reviewed changes
Copy link
Member
@goedderz goedderz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KVS85
Copy link
Contributor
KVS85 commented Oct 16, 2019

Tests blue except unrelated timeout in http_server suite.

@KVS85
Copy link
Contributor
KVS85 commented Oct 16, 2019

https://172.16.10.101/job/arangodb-matrix-pr-windows/796/

@KVS85
Copy link
Contributor
KVS85 commented Oct 16, 2019

Test blue.

@KVS85 KVS85 merged commit 69747bc into 3.4 Oct 16, 2019
@KVS85 KVS85 deleted the bug-fix-3.4/disallow-subqueries-in-prune branch October 16, 2019 16:20
@goedderz goedderz mentioned this pull request Aug 28, 2020
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KVS85 KVS85 KVS85 approved these changes

@goedderz goedderz goedderz approved these changes

Assignees
No one assigned
Labels
9 Waiting for Jenkins
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
3 participants
@jsteemann @KVS85 @goedderz
0