8000 Forbid subqueries in PRUNE in additional cases by goedderz · Pull Request #12557 · arangodb/arangodb · GitHub
[go: up one dir, main page]

Skip to content

Forbid subqueries in PRUNE in additional cases #12557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 23, 2020

Conversation

goedderz
Copy link
Member
@goedderz goedderz commented Aug 28, 2020

Scope & Purpose

Subqueries cannot work in PRUNE and should be forbidden (see #10232/#10231/#10266). However, one case of subqueries was missing in the grammar.

  • 💩 Bugfix
  • 📖 CHANGELOG entry made
  • 💪 The behavior in this PR was manually tested
  • 💻 The behavior change can be verified via automatic tests

Backports:

Related Information

Testing & Verification

  • This PR adds tests that were used to verify all changes:
  • Added Regression Tests

Documentation

  • Added a Changelog Entry

@goedderz goedderz added the 1 Bug label Aug 28, 2020
@goedderz goedderz added this to the devel milestone Aug 28, 2020
@goedderz goedderz requested review from jsteemann and mchacki August 28, 2020 14:11
@goedderz goedderz self-assigned this Aug 28, 2020
@goedderz
Copy link
Member Author

Copy link
Member
@mchacki mchacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general LGTM.

However I think we are required to commit the generated grammar files, otherwise the non-maintainer version will not contain this bug-fix.

@goedderz
Copy link
Member Author
goedderz commented Sep 1, 2020

@goedderz
Copy link
Member Author
goedderz commented Sep 1, 2020

image

Copy link
Member
@mchacki mchacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jsteemann jsteemann merged commit e8f3839 into devel Sep 23, 2020
@jsteemann jsteemann deleted the bug-fix/forbid-all-subqueries-in-prune branch September 23, 2020 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0