feature: clang-tidy&format #10209
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| build/compile_commands.json |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| #!/usr/bin/env bash | ||
| set -u | ||
|
There was a problem hiding this comment. is this like clang-format-diff ? There was a problem hiding this comment. No - This checks the clang version to be used. But instead of using the logic provided by franks awesome find command one could have come up with some regular expression for clang-format-diff. There was a problem hiding this comment. I have changed the script to use clang-format-diff |
||
|
|
||
| ## locate executable | ||
| clang_format="${ARANGODB_CLANG_FORMAT:-""}" | ||
| clang_format_version="${ARANGODB_CLANG_FORMAT_VERSION:-"6.0.1"}" | ||
|
|
||
| # fallback if nothing is found | ||
| if [[ -z $clang_format ]]; then | ||
| for candidate in "$HOME/.local/bin/clang-format" "clang-format-arangodb" "clang-format-6" "clang-format"; do | ||
| echo "checking candidate $candidate" | ||
| path="$(type -p ${candidate})" | ||
| if [[ -n $path ]]; then | ||
| clang_format="$path" | ||
| echo "selecting this candidate" | ||
| break; | ||
| fi | ||
| done | ||
| else | ||
| echo "clang-format provided by environment" | ||
| fi | ||
|
|
||
| # fallback if nothing is found | ||
| if [[ -z $clang_format ]]; then | ||
| echo "using fallback" | ||
| clang_format="clang-format" | ||
| fi | ||
|
|
||
| ## check version | ||
| echo "checking version of $clang_format" | ||
| version_string=$(${clang_format} --version) | ||
| re=".*version ${clang_format_version}.*" | ||
| if ! [[ $version_string =~ $re ]]; then | ||
| echo "your version: '$version_string' does not match version 6.0.1" | ||
| exit 1 | ||
| fi | ||
|
|
||
|
|
||
| ## find relevant files | ||
| files="$( | ||
| find arangod arangosh lib enterprise \ | ||
| -name Zip -prune -o \ | ||
| -type f "(" -name "*.cpp" -o -name "*.h" ")" \ | ||
| "!" "(" -name "tokens.*" -o -name "v8-json.*" -o -name "voc-errors.*" -o -name "grammar.*" -o -name "xxhash.*" -o -name "exitcodes.*" ")" | ||
| )" | ||
|
|
||
| git_files=$(git diff --name-only) | ||
| files_final=() | ||
| for gf in ${git_files[@]}; do | ||
| echo "---------------------" | ||
| for f in ${files[@]}; do | ||
| echo "$gf -- $f" | ||
| if [[ $gf == $f ]]; then | ||
| files_final+=( "$f" ) | ||
| continue | ||
| fi | ||
| done | ||
| done | ||
|
|
||
| # do final formatting | ||
| ${clang_format} -i -verbose -style=file ${files_final[@]} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| #!/usr/bin/env bash | ||
| set -u | ||
|
|
||
| # Make any failure in piped commands be reflected in the exit code. | ||
| set -o pipefail | ||
|
|
||
| readonly bash_source_dir="$(dirname $(readlink -f ${BASH_SOURCE[0]}))" | ||
|
|
||
|
|
||
| ## locate executable | ||
| clang_format="${ARANGODB_CLANG_FORMAT:-""}" | ||
| clang_format_version="${ARANGODB_CLANG_FORMAT_VERSION:-"9.0.0"}" | ||
|
|
||
| # fallback if nothing is found | ||
| if [[ -z $clang_format ]]; then | ||
| for candidate in "$HOME/.local/bin/clang-format" "clang-format-arangodb" "clang-format-9" "clang-format"; do | ||
| echo "checking candidate $candidate" | ||
| path="$(type -p ${candidate})" | ||
| if [[ -n $path ]]; then | ||
| clang_format="$path" | ||
| echo "selecting this candidate" | ||
| break; | ||
| fi | ||
| done | ||
| else | ||
| echo "clang-format provided by environment" | ||
| fi | ||
|
|
||
| # fallback if nothing is found | ||
| if [[ -z $clang_format ]]; then | ||
| echo "using fallback" | ||
| clang_format="clang-format" | ||
| fi | ||
|
|
||
| ## check version | ||
| echo "checking version of $clang_format" | ||
| version_string=$(${clang_format} --version) | ||
| re=".*version ${clang_format_version}.*" | ||
| if ! [[ $version_string =~ $re ]]; then | ||
| echo "your version: '$version_string' does not match version 6.0.1" | ||
| exit 1 | ||
| fi | ||
|
|
||
|
|
||
| diff="$(git diff -U0 --no-color HEAD^)" | ||
| if type colordiff 2>/dev/null; then | ||
| #need pipefail option | ||
| ${bash_source_dir}/lib/clang-format-diff.py --verbose -binary "${clang_format}" -style=file -p1 <<<"$diff" | colordiff -u3 | ||
| else | ||
| ${bash_source_dir}/lib/clang-format-diff.py --verbose -binary "${clang_format}" -style=file -p1 <<<"$diff" | ||
| fi | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| #!/usr/bin/env bash | ||
| set -u | ||
|
|
||
| ## locate executable | ||
| clang_format="${ARANGODB_CLANG_FORMAT:-""}" | ||
| clang_format_version="${ARANGODB_CLANG_FORMAT_VERSION:-"6.0.1"}" | ||
|
|
||
| # fallback if nothing is found | ||
| if [[ -z $clang_format ]]; then | ||
| for candidate in "$HOME/.local/bin/clang-format" "clang-format-arangodb" "clang-format-6" "clang-format"; do | ||
| echo "checking candidate $candidate" | ||
| path="$(type -p ${candidate})" | ||
| if [[ -n $path ]]; then | ||
| clang_format="$path" | ||
| echo "selecting this candidate" | ||
| break; | ||
| fi | ||
| done | ||
| else | ||
| echo "clang-format provided by environment" | ||
| fi | ||
|
|
||
| # fallback if nothing is found | ||
| if [[ -z $clang_format ]]; then | ||
| echo "using fallback" | ||
| clang_format="clang-format" | ||
| fi | ||
|
|
||
| ## check version | ||
| echo "checking version of $clang_format" | ||
| version_string=$(${clang_format} --version) | ||
| re=".*version ${clang_format_version}.*" | ||
| if ! [[ $version_string =~ $re ]]; then | ||
| echo "your version: '$version_string' does not match version 6.0.1" | ||
| exit 1 | ||
| fi | ||
|
|
||
|
|
||
| ## find relevant files | ||
| files="$( | ||
| find arangod arangosh lib enterprise \ | ||
| -name Zip -prune -o \ | ||
| -type f "(" -name "*.cpp" -o -name "*.h" ")" \ | ||
| "!" "(" -name "tokens.*" -o -name "v8-json.*" -o -name "voc-errors.*" -o -name "grammar.*" -o -name "xxhash.*" -o -name "exitcodes.*" ")" | ||
| )" | ||
|
|
||
| # do final formatting | ||
| ${clang_format} -i -verbose -style=file ${files[@]} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| #!/bin/bash | ||
|
|
||
| #!/usr/bin/env bash | ||
| set -u | ||
|
|
||
| ## locate executable | ||
| clang_tidy="${ARANGODB_CLANG_TIDY:-""}" | ||
| clang_tidy_version="${ARANGODB_CLANG_TIDY_VERSION:-"9.0.0"}" | ||
|
|
||
| # fallback if nothing is found | ||
| if [[ -z $clang_tidy ]]; then | ||
| for candidate in "$HOME/.local/bin/clang-tidy" "clang-tidy-arangodb" "clang-tidy-9" "clang-tidy"; do | ||
| echo "checking candidate $candidate" | ||
| path="$(type -p ${candidate})" | ||
| if [[ -n $path ]]; then | ||
| clang_tidy="$path" | ||
| echo "selecting this candidate" | ||
| break; | ||
| fi | ||
| done | ||
| else | ||
| echo "clang-tidy provided by environment" | ||
| fi | ||
|
|
||
| # fallback if nothing is found | ||
| if [[ -z $clang_tidy ]]; then | ||
| echo "using fallback" | ||
| clang_tidy="clang-tidy" | ||
| fi | ||
|
|
||
| ## check version | ||
| echo "checking version of $clang_tidy" | ||
| version_string=$(${clang_tidy} --version) | ||
| re=".*version ${clang_tidy_version}.*" | ||
| if ! [[ $version_string =~ $re ]]; then | ||
| echo "your version: '$version_string' does not match version 6.0.1" | ||
| exit 1 | ||
| fi | ||
|
|
||
| ## find relevant files | ||
| #-type f "(" -name "*.cpp" -o -name "*.h" ")" \ | ||
| files="$( | ||
| find arangod arangosh lib enterprise \ | ||
| -name Zip -prune -o \ | ||
| -type f "(" -name "*.cpp" ")" \ | ||
| "!" "(" -name "tokens.*" -o -name "v8-json.*" -o -name "voc-errors.*" -o -name "grammar.*" -o -name "xxhash.*" -o -name "exitcodes.*" ")" | ||
| )" | ||
|
|
||
| ${clang_tidy} --quiet -checks=-*,clang-analyzer-*,-clang-analyzer-cplusplus* ${files} | ||
ObiWahn marked this conversation as resolved.
Show resolved
Hide resolved
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.