8000 feature: clang-tidy&format by ObiWahn · Pull Request #10209 · arangodb/arangodb · GitHub
[go: up one dir, main page]

Skip to content

feature: clang-tidy&format #10209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 51 commits into from
Closed

feature: clang-tidy&format #10209

wants to merge 51 commits into from

Conversation

ObiWahn
Copy link
Contributor
@ObiWahn ObiWahn commented Oct 9, 2019

@ObiWahn ObiWahn requested a review from fceller October 14, 2019 11:39
@@ -0,0 +1,61 @@
#!/usr/bin/env bash
set -u
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this like clang-format-diff ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No - This checks the clang version to be used.

But instead of using the logic provided by franks awesome find command one could have come up with some regular expression for clang-format-diff.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have changed the script to use clang-format-diff

ObiWahn and others added 2 commits October 15, 2019 08:39
Co-Authored-By: Simon <simon@graetzer.org>
Co-Authored-By: Wilfried Goesgens <willi@arangodb.com>
@ObiWahn ObiWahn requested a review from graetzer October 15, 2019 06:43
@ObiWahn
Copy link
Contributor Author
ObiWahn commented Oct 15, 2019

Does readlink -f work on macOS?

@ObiWahn
Copy link
Contributor Author
ObiWahn commented Mar 9, 2020

Closed as there is not sufficient interest.

@ObiWahn ObiWahn closed this Mar 9, 2020
@jsteemann jsteemann deleted the feature/clang-tidy-format branch March 9, 2022 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0