8000 [3.5] Fix AQL skip in cluster sometimes causing documents to be forgotten by goedderz · Pull Request #10199 · arangodb/arangodb · GitHub
[go: up one dir, main page]
Skip to content

[3.5] Fix AQL skip in cluster sometimes causing documents to be forgotten #10199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 11, 2019
Merged

[3.5] Fix AQL skip in cluster sometimes causing documents to be forgotten #10199

merged 5 commits into from
Oct 11, 2019

Conversation

goedderz
Copy link
Member
@goedderz goedderz commented Oct 9, 2019 •
edited
Loading

Backport of #10190.

Note that the situation where this bug appears can never arise in 3.5. Though there is actually no bug to be fixed, this is just to be on the safe side.

@goedderz
Bugfix for recurring Jenkins error in api-simple-modify-example-clust…
6483dcd 
…er-spec.rb (#10190)

DependencyProxy::skipSome did not work correctly with multiple
dependencies if atMost was reached, returning DONE early.
@goedderz goedderz added 1 Bug 3 AQL Query language related labels Oct 9, 2019
@goedderz goedderz added this to the 3.5 milestone Oct 9, 2019
@goedderz goedderz self-assigned this Oct 9, 2019
@goedderz
Copy link
Member Author
goedderz commented Oct 9, 2019

http://jenkins.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr/6648/

@goedderz goedderz mentioned this pull request Oct 9, 2019
Merged
5 tasks
@goedderz goedderz added the 9 WIP label Oct 9, 2019
mchacki
mchacki approved these changes Oct 9, 2019
View reviewed changes
Copy link
Member
@mchacki mchacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goedderz
Copy link
Member Author

http://jenkins01.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr/6676/

@KVS85 KVS85 merged commit 4c6ab4d into 3.5 Oct 11, 2019
@KVS85 KVS85 deleted the bug-fix-3.5/fix-simple-example_dep-proxy-skip-some branch October 11, 2019 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchacki mchacki mchacki approved these changes

Assignees

@goedderz goedderz

Labels
1 Bug 3 AQL Query language related 9 Ready to Merge
Projects
None yet
Milestone
3.5
Development

Successfully merging this pull request may close these issues.
3 participants
@goedderz @mchacki @KVS85
0