Bugfix for recurring Jenkins error in api-simple-modify-example-cluster-spec.rb #10190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er-spec.rb DependencyProxy::skipSome did not work correctly with multiple dependencies if atMost was reached, returning DONE early.
|
http://jenkins.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr/6639/ |
|
@goedderz : cool, I was about to investigate this locally just now. |
jsteemann
approved these changes
Oct 8, 2019
|
Looks to me as if it fixes the problem. |
goedderz
added a commit
that referenced
this pull request
Oct 9, 2019
…er-spec.rb (#10190) DependencyProxy::skipSome did not work correctly with multiple dependencies if atMost was reached, returning DONE early.
goedderz
added a commit
that referenced
this pull request
Oct 9, 2019
…er-spec.rb (#10190) DependencyProxy::skipSome did not work correctly with multiple dependencies if atMost was reached, returning DONE early.
goedderz
added a commit
that referenced
this pull request
Oct 9, 2019
mchacki
pushed a commit
that referenced
this pull request
Oct 9, 2019
goedderz
added a commit
that referenced
this pull request
Oct 10, 2019
goedderz
added a commit
that referenced
this pull request
Oct 10, 2019
goedderz
added a commit
that referenced
this pull request
Oct 10, 2019
mchacki
pushed a commit
that referenced
this pull request
Oct 10, 2019
* Added regression test for #10190
KVS85
pushed a commit
that referenced
this pull request
Oct 11, 2019
…tten (#10199) * Bugfix for recurring Jenkins error in api-simple-modify-example-cluster-spec.rb (#10190) DependencyProxy::skipSome did not work correctly with multiple dependencies if atMost was reached, returning DONE early. * Updated CHANGELOG * Deleted CHANGELOG entry * Added regression test for #10190 * Added missing include
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope & Purpose
Fix an error we've seen occasionally during PR tests in
api-simple-modify-example-cluster-spec.rb.DependencyProxy::skipSomedid not work correctly with multiple dependencies ifatMostwas reached, returningDONEearly.Testing & Verification
Documentation
No CHANGELOG entry, as it did never affect 3.5.