8000 test: re-enable localize warning check by cexbrayat · Pull Request #27970 · angular/angular-cli · GitHub
[go: up one dir, main page]
Skip to content

test: re-enable localize warning check #27970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
clydin merged 1 commit into from
Jul 1, 2024
Merged

test: re-enable localize warning check #27970

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions tests/legacy-cli/e2e/tests/i18n/extract-ivy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { join } from 'path';
import { getGlobalVariable } from '../../utils/env';
import { expectFileToMatch, writeFile } from '../../utils/fs';
import { installPackage, uninstallPackage } from '../../utils/packages';
import { uninstallPackage } from '../../utils/packages';
import { ng } from '../../utils/process';
import { expectToFail } from '../../utils/utils';
import { readNgVersion } from '../../utils/version';
Expand Down Expand Up @@ -36,15 +36,16 @@ export default async function () {
// Install correct version
let localizeVersion = '@angular/localize@' + readNgVersion();
if (getGlobalVariable('argv')['ng-snapshots']) {
localizeVersion = require('../../ng-snapshot/package.json').dependencies['@angular/localize'];
// The snapshots job won't work correctly because 'ng add' doesn't support github URLs
// localizeVersion = require('../../ng-snapshot/package.json').dependencies['@angular/localize'];
return;
}
await installPackage(localizeVersion);
await ng('add', localizeVersion, '--skip-confirmation');

// Should not show any warnings when extracting
const { stderr: message5 } = await ng('extract-i18n');
if (message5.includes('WARNING')) {
// TODO: enable once https://github.com/angular/angular/pull/56300 is released.
// throw new Error('Expected no warnings to be shown. STDERR:\n' + message5);
throw new Error('Expected no warnings to be shown. STDERR:\n' + message5);
}

await expectFileToMatch('messages.xlf', 'Hello world');
Expand Down
0