test: re-enable localize warning check#27970
Merged
clydin merged 1 commit intoangular:mainfrom Jul 1, 2024
Merged
Conversation
alan-agius4
approved these changes
Jul 1, 2024
Collaborator
|
@cexbrayat, thank you for this. |
Member
Author
|
Oh but it looks like it actually fails. edit: I tried await ng('add', `@angular/localize@${localizeVersion}`, '--skip-confirmation'); |
420f375 to
69c6b4b
Compare
alan-agius4
approved these changes
Jul 1, 2024
Collaborator
|
@cexbrayat, you can check https://github.com/angular/angular-cli/blob/main/tests/legacy-cli/e2e/tests/commands/add/version-specifier.ts for an example. |
69c6b4b to
5c98476
Compare
Member
Author
|
@alan-agius4 I think I figured it out 👍 |
alan-agius4
reviewed
Jul 1, 2024
It can be re-enabled now that angular/angular#56300 have been released in v18.1.0-next.2
5c98476 to
f55051e
Compare
Member
|
The changes were merged into the following branches: main, 18.1.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check to confirm your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the new behavior?
It can be re-enabled now that angular/angular#56300 have been released in v18.1.0-next.2
Does this PR introduce a breaking change?
Other information