8000 fix(core): unregister `onDestroy` in `outputToObservable` by arturovt · Pull Request #61882 · angular/angular · GitHub
[go: up one dir, main page]
Skip to content

fix(core): unregister onDestroy in outputToObservable #61882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(core): unregister onDestroy in outputToObservable #61882

wants to merge 1 commit into from

Conversation

arturovt
Copy link
Contributor
@arturovt arturovt commented Jun 4, 2025

We should remove the onDestroy listener once subscription is unsubscribed because components might not be destroyed yet, but they still would capture subscribers.

@arturovt
fix(core): unregister onDestroy in outputToObservable
6c121e5 
We should remove the `onDestroy` listener once subscription is unsubscribed because components might not be destroyed yet, but they still would capture subscribers.
@pullapprove pullapprove bot requested a review from crisbeto June 4, 2025 21:14
@angular-robot angular-robot bot added the area: core Issues related to the framework runtime label Jun 4, 2025
@ngbot ngbot bot added this to the Backlog milestone Jun 4, 2025
@thePunderWoman thePunderWoman removed the request for review from crisbeto June 5, 2025 06:10
@thePunderWoman thePunderWoman added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Jun 5, 2025
@thePunderWoman
Copy link
Contributor

Caretaker note: this is safe to merge. the failing G3 test is a flake.

@pkozlowski-opensource
Copy link
Member

This PR was merged into the repository by commit e81ea0c.

The changes were merged into the following branches: main, 20.0.x

pkozlowski-opensource pushed a commit that referenced this pull request Jun 5, 2025
@arturovt @pkozlowski-opensource
fix(core): unregister onDestroy in outputToObservable (#61882)
1cd23be 
We should remove the `onDestroy` listener once subscription is unsubscribed because components might not be destroyed yet, but they still would capture subscribers.

PR Close #61882
@arturovt arturovt deleted the fix/core-outputToObservable-unregister branch June 5, 2025 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeanMeche JeanMeche JeanMeche approved these changes

@thePunderWoman thePunderWoman thePunderWoman approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
4 participants
@arturovt @thePunderWoman @pkozlowski-opensource @JeanMeche
0