fix(core): unregister onDestroy in outputToObservable (#61882)

arturovt · pkozlowski-opensource · commit 1cd23be57e68 · 2025-06-05T11:16:57.000+02:00
We should remove the `onDestroy` listener once subscription is unsubscribed because components might not be destroyed yet, but they still would capture subscribers. PR Close #61882
diff --git a/packages/core/rxjs-interop/src/output_to_observable.ts b/packages/core/rxjs-interop/src/output_to_observable.ts
@@ -24,9 +24,12 @@ export function outputToObservable<T>(ref: OutputRef<T>): Observable<T> {
     // Complete the observable upon directive/component destroy.
     // Note: May be `undefined` if an `EventEmitter` is declared outside
     // of an injection context.
-    destroyRef?.onDestroy(() => observer.complete());
+    const unregisterOnDestroy = destroyRef?.onDestroy(() => observer.complete());
 
     const subscription = ref.subscribe((v) => observer.next(v));
-    return () => subscription.unsubscribe();
+    return () => {
+      subscription.unsubscribe();
+      unregisterOnDestroy?.();
+    };
   });
 }
