8000 Backport: feat(compiler): add support for the typeof keyword in template expressions #58183 by aceArt-GmbH · Pull Request #59357 · angular/angular · GitHub
[go: up one dir, main page]
Skip to content

Backport: feat(compiler): add support for the typeof keyword in template expressions #58183 #59357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Backport: feat(compiler): add support for the typeof keyword in template expressions #58183 #59357

wants to merge 1 commit into from

Conversation

aceArt-GmbH
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

This is just a backport of #58183 to v18

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Currently typeof is not usable on angular <v19.

Issue Number: #58183

What is the new behavior?

This is not a breaking change, so allow it in v18 too.
Many projects can't make major updates quickly

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Do you make/accept backports of this kind?

@JeanMeche
feat(compiler): add support for the typeof keyword in template expr…
4aa8050 
…essions. (angular#58183)

This commit adds the support for `typeof` in template expressions like interpolation, bindings, control flow blocks etc.

PR Close angular#58183
@google-cla Google CLA
Copy link
google-cla bot commented Jan 3, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@pullapprove pullapprove bot requested review from alxhub and JoostK January 3, 2025 12:56
@angular-robot angular-robot bot added detected: feature PR contains a feature commit area: compiler Issues related to `ngc`, Angular's template compiler labels Jan 3, 2025
@ngbot ngbot bot added this to the Backlog milestone Jan 3, 2025
@aceArt-GmbH
Copy link
Author

affected tests will be executed on our CI infrastructure. So if you forgot to run some affected tests which would fail, GitHub will indicate the error state and present you the failures

is this true for none main branches?

@JeanMeche
Copy link
Member

Hi,
We don't do backports of features on LTS branches. Only security fixes and major bugfixes are being backported.

Thank you for your understanding.

@JeanMeche JeanMeche closed this Jan 3, 2025
@aceArt-GmbH aceArt-GmbH deleted the backport-typeof branch January 3, 2025 14:55
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alxhub alxhub Awaiting requested review from alxhub

@JoostK JoostK Awaiting requested review from JoostK

Assignees
No one assigned
Labels
area: compiler Issues related to `ngc`, Angular's template compiler detected: feature PR contains a feature commit
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
2 participants
@aceArt-GmbH @JeanMeche
0