feat(compiler): add support for the typeof keyword in template expressions
#58183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52e611b to
ada8636
Compare
JeanMeche
commented
Oct 14, 2024
| @@ -436,18 +452,6 @@ function isIdentifierStart(code: number): boolean { | |||
| ); | |||
| } | |||
|
|
|||
| export function isIdentifier(input: string): boolean { | |||
There was a problem hiding this comment.
This function was unused.
ada8636 to
da0b23f
Compare
da0b23f to
7da26d8
Compare
7da26d8 to
9aa8ff2
Compare
crisbeto
reviewed
Oct 14, 2024
| @@ -99,6 +111,10 @@ export class Token { | |||
| return this.type == TokenType.Keyword && this.strValue == 'this'; | |||
| } | |||
|
|
|||
| isKeywordTypeof(): boolean { | |||
| return this.type == TokenType.Keyword && this.strValue == 'typeof'; | |||
There was a problem hiding this comment.
These should be triple equals.
There was a problem hiding this comment.
none of the method above use ===, should we update them too ?
|
This is how random discussions in the Angular team Slack turn into PRs like that 🔥 |
…essions. This commit adds the support for `typeof` in template expressions like interpolation, bindings, control flow blocks etc.
207a73a to
992769f
Compare
JoostK
approved these changes
Oct 15, 2024
crisbeto
reviewed
Oct 15, 2024
packages/compiler-cli/test/compliance/test_cases/r3_view_compiler/operators.ts
Show resolved
Hide resolved
crisbeto
approved these changes
Oct 15, 2024
|
This PR was merged into the repository by commit 0c9d721. The changes were merged into the following branches: main |
devversion
added a commit
to devversion/angular
that referenced
this pull request
Oct 16, 2024
…ate expressions. (angular#58183)" This reverts commit 0c9d721. This breaks CI jobs in `main`, and sync into google3. PR was green and presubmit too; so I'm suspecting some rebase conflicts with other changes being merged at the same time.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
aceArt-GmbH
pushed a commit
to aceArt-GmbH/angular
that referenced
this pull request
Jan 3, 2025
…essions. (angular#58183) This commit adds the support for `typeof` in template expressions like interpolation, bindings, control flow blocks etc. PR Close angular#58183
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the support for
typeofin template expressions like interpolations, bindings, control flow blocks etc.