8000 feat(common): Add an`Intl` implementation for the i18n sub-system. by JeanMeche · Pull Request #55283 · angular/angular · GitHub
[go: up one dir, main page]
Skip to content

feat(common): Add anIntl implementation for the i18n sub-system. #55283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat(common): Add anIntl implementation for the i18n sub-system. #55283

wants to merge 4 commits into from

Conversation

JeanMeche
Copy link
Member
@JeanMeche JeanMeche commented Apr 10, 2024 •
edited
Loading

Angular's i18n subsystem is responsible for providing localised formatting of numbers, percents, percentages and dates.
This feature replaces the default implementation of the i18N subsystem.

The commits add a new implementation that relies on the platform-provided Intl API.

With this new implementation relying on a platform API, it is not necessary anymore the load locale files (See #20487) .

The new implementation is available via an opt-in : useIntlImplementation().

This feature fixes the following issues:

Closes #54470

@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Apr 10, 2024
@JeanMeche JeanMeche force-pushed the poc-intl-date branch 2 times, most recently from 6c939c3 to 0ceb875 Compare April 10, 2024 15:02
@angular-robot angular-robot bot added the detected: deprecation PR contains a commit with a deprecation label Apr 10, 2024
@JeanMeche JeanMeche changed the title feat(common): Add support for i18N using the Intl API feat(common): Add and enable the Intl implementation for the i18n sub-system. Apr 10, 2024
alan-agius4
alan-agius4 reviewed Apr 10, 2024
View reviewed changes
@JeanMeche JeanMeche changed the title feat(common): Add and enable the Intl implementation for the i18n sub-system. feat(common): Add and enable the Intl implementation for the i18n sub-system. Apr 10, 2024
@JeanMeche JeanMeche added feature Issue that requests a new feature breaking changes area: i18n Issues related to localization and internationalization and removed detected: feature PR contains a feature commit labels Apr 11, 2024
@ngbot ngbot bot added this to the Backlog milestone Apr 11, 2024
@JeanMeche JeanMeche added the action: review The PR is still awaiting reviews from at least one requested reviewer label Apr 11, 2024
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Apr 11, 2024
@alxhub alxhub self-assigned this Apr 11, 2024
@angular-robot angular-robot bot added the detected: breaking change PR contains a commit with a breaking change label Apr 12, 2024
@JeanMeche JeanMeche force-pushed the poc-intl-date branch 2 times, most recently from 767753e to 1ca64d6 Compare April 12, 2024 10:27
@JeanMeche JeanMeche marked this pull request as ready for review April 12, 2024 10:42
@pullapprove pullapprove bot requested review from AndrewKushnir and atscott April 12, 2024 10:42
@JeanMeche JeanMeche mentioned this pull request Apr 16, 2024
Closed
@angular-robot angular-robot bot removed the detected: breaking change PR contains a commit with a breaking change label Apr 18, 2024
@angular-robot angular-robot bot removed the area: build & ci Related the build and CI infrastructure of the project label May 9, 2024
@jnizet jnizet mentioned this pull request May 17, 2024
Merged
1 task
@JeanMeche JeanMeche force-pushed the poc-intl-date branch 2 times, most recently from 39678f2 to 015b124 Compare May 24, 2024 00:27
@JeanMeche JeanMeche mentioned this pull request May 24, 2024
Open
@JeanMeche JeanMeche mentioned this pull request Jun 3, 2024
Closed
3 tasks
@JeanMeche JeanMeche mentioned this pull request Jul 9, 2024
Open
@angular-robot angular-robot bot added the area: common Issues related to APIs in the @angular/common package label Jul 30, 2024
@JeanMeche JeanMeche mentioned this pull request Jul 30, 2024
Open
@JeanMeche
feat(common): add Intl implementation to format numbers, percents a…
f279e7f 
…nd currencies

This commit adds an `Intl` implementation to format numbers, percents and currencies.
The implementation is based on the `Intl` API and allows to drop the static imports for the locale date files.

fixes angular#33803
@JeanMeche
feat(common): use the Intl API to for plurals
0399cc6 
With this commit, plurals formatting does not depend on the CLDR locale data anymore.
@JeanMeche
feat(common): add an Intl API implementation for date formatting.
d4e74a3 
With this commit, the Intl implementation because the default one and doesn't require the CLDR locale data imports anymore.

Opt-out is possible by invoking `useLegacyDateFormatting()` ahead of bootstrap.

BREAKING CHANGE: Some custom date format aren't supported any more (`cccccc`, `EEEEEE`, `aaaaa`, `b` to `bbbbb` and `B` to `BBBBB`)
The `DatePipe` will not support offset timezone anymore, use IANA timezones instead .
@JeanMeche
fixup! feat(common): add Intl implementation to format numbers, per…
8b33b29 
…cents and currencies
@JeanMeche JeanMeche mentioned this pull request Sep 22, 2024
Closed
@pullapprove pullapprove bot removed the request for review from atscott October 17, 2024 16:55
@alxhub alxhub removed this from the v19 Feature Freeze Candidates milestone Oct 21, 2024
@ngbot ngbot bot added this to the Backlog milestone Oct 21, 2024
@JeanMeche JeanMeche modified the milestones: Backlog, v20 candidates Feb 11, 2025
@JeanMeche JeanMeche removed this from the v20 candidates milestone Apr 24, 2025
@ngbot ngbot bot added this to the Backlog milestone Apr 24, 2025
@csvn
Copy link
Contributor
csvn commented May 16, 2025

I hope I'm not being a nuisance, but what is the status for this PR? I see it was removed from v20 milestone recently, and the last thing mentioned was in #57916:

I hope that we can ship it with v19, mid November.

  • Since using Intl is opt-in, can't this land in a minor version?
  • I looked through tests and code a bit, is there any work left for this to be "done"?

I've been considering replacing @angular/common in our application with pipes/helpers based on Intl so we can format based on the users current locale instead, which is a lot messier when registerLocaleData() is required to use. I thought we'd wait perhaps for this PR to land though, to avoid building something custom if it will be supported in Angular. 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devversion devversion devversion left review comments

@alan-agius4 alan-agius4 alan-agius4 left review comments

@AndrewKushnir AndrewKushnir Awaiting requested review from AndrewKushnir

At least 1 approving review is required to merge this pull request.

Assignees

@alxhub alxhub

@AndrewKushnir AndrewKushnir

Labels
action: review The PR is still awaiting reviews from at least one requested reviewer area: common Issues related to APIs in the @angular/common package area: i18n Issues related to localization and internationalization detected: breaking change PR contains a commit with a breaking change detected: feature PR contains a feature commit feature Issue that requests a new feature target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

Use platform Intl APIs in Angular's i18n subsystem
6 participants
@JeanMeche @AndrewKushnir @csvn @devversion @alan-agius4 @alxhub
0