-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Make paging-testing multiplatform by moving everything to common*
#609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
Add Atomic shims to
paging-testing
- Loading branch information
commit 9bbb49472586b5eb0c96429d74cfcdc20a913ea0
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34 changes: 34 additions & 0 deletions
34
paging/paging-testing/src/commonMain/kotlin/androidx/paging/testing/internal/Atomics.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| /* | ||
| * Copyright 2023 The Android Open Source Project | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package androidx.paging.testing.internal | ||
|
|
||
| internal expect class AtomicInt(initialValue: Int) { | ||
| fun get(): Int | ||
| fun set(value: Int) | ||
| } | ||
|
|
||
| internal expect class AtomicBoolean(initialValue: Boolean) { | ||
| fun get(): Boolean | ||
| fun set(value: Boolean) | ||
| fun compareAndSet(expect: Boolean, update: Boolean): Boolean | ||
| } | ||
|
|
||
| internal expect class AtomicRef<T>(initialValue: T) { | ||
| fun get(): T | ||
| fun set(value: T) | ||
| fun getAndSet(value: T): T | ||
| } |
23 changes: 23 additions & 0 deletions
23
paging/paging-testing/src/jvmMain/kotlin/androidx/paging/testing/internal/Atomics.jvm.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| /* | ||
| * Copyright 2023 The Android Open Source Project | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| @file:Suppress("ACTUAL_WITHOUT_EXPECT") // https://youtrack.jetbrains.com/issue/KT-37316 | ||
| package androidx.paging.testing.internal | ||
|
|
||
| internal actual typealias AtomicInt = java.util.concurrent.atomic.AtomicInteger | ||
|
|
||
| internal actual typealias AtomicBoolean = java.util.concurrent.atomic.AtomicBoolean | ||
|
|
||
| internal actual typealias AtomicRef<T> = java.util.concurrent.atomic.AtomicReference<T> |
66 changes: 66 additions & 0 deletions
66
...g/paging-testing/src/nativeMain/kotlin/androidx/paging/testing/internal/Atomics.native.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| /* | ||
| * Copyright 2023 The Android Open Source Project | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| @file:OptIn(ExperimentalForeignApi::class) | ||
|
|
||
| package androidx.paging.testing.internal | ||
|
|
||
| import kotlinx.atomicfu.AtomicBoolean as AtomicFuAtomicBoolean | ||
| import kotlinx.atomicfu.AtomicInt as AtomicFuAtomicInt | ||
| import kotlinx.atomicfu.AtomicRef as AtomicFuAtomicRef | ||
| import kotlinx.atomicfu.atomic | ||
| import kotlinx.cinterop.ExperimentalForeignApi | ||
|
|
||
| internal actual class AtomicInt actual constructor(initialValue: Int) { | ||
| private var delegate: AtomicFuAtomicInt = atomic(initialValue) | ||
| private var property by delegate | ||
|
|
||
| actual fun get(): Int = property | ||
|
|
||
| actual fun set(value: Int) { | ||
| property = value | ||
| } | ||
| } | ||
|
|
||
| internal actual class AtomicBoolean actual constructor(initialValue: Boolean) { | ||
| private var delegate: AtomicFuAtomicBoolean = atomic(initialValue) | ||
| private var property by delegate | ||
|
|
||
| actual fun get(): Boolean = property | ||
|
|
||
| actual fun set(value: Boolean) { | ||
| property = value | ||
| } | ||
|
|
||
| actual fun compareAndSet(expect: Boolean, update: Boolean): Boolean { | ||
| return delegate.compareAndSet(expect, update) | ||
| } | ||
| } | ||
|
|
||
| internal actual class AtomicRef<T> actual constructor(initialValue: T) { | ||
| private var delegate: AtomicFuAtomicRef<T> = atomic(initialValue) | ||
| private var property by delegate | ||
|
|
||
| actual fun get(): T = property | ||
|
|
||
| actual fun set(value: T) { | ||
| property = value | ||
| } | ||
|
|
||
| actual fun getAndSet(value: T): T { | ||
| return delegate.getAndSet(value) | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.