8000 Make `paging-testing` multiplatform by moving everything to `common*` by veyndan · Pull Request #609 · androidx/androidx · GitHub
[go: up one dir, main page]
Skip to content

Make paging-testing multiplatform by moving everything to common* #609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
veyndan wants to merge 3 commits into from
Closed

Make paging-testing multiplatform by moving everything to common* #609

veyndan wants to merge 3 commits into from

Conversation

@veyndan
Copy link
Contributor
@veyndan veyndan commented Sep 9, 2023

Test: ./gradlew paging:paging-testing:allTests

@veyndan veyndan requested review from dlam and yigit as code owners September 9, 2023 13:40
veyndan
veyndan commented Sep 9, 2023
View reviewed changes
@veyndan
Copy link
Contributor Author
veyndan commented Sep 9, 2023

CI should be fixed by https://android-review.googlesource.com/c/platform/frameworks/support/+/2746657. I'll rebase this PR once that has been merged.

claraf3
claraf3 approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member
@claraf3 claraf3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@claraf3 claraf3 requested review from ianhanniballake and removed request for dlam and yigit September 11, 2023 17:52
@dlam
Copy link
Member
dlam commented Sep 11, 2023

Copybara is having trouble mirroring this because of the conflict.

@claraf3
Copy link
Member
claraf3 commented Sep 11, 2023

Infra recently upgraded their build and changed androidTest references to androidUnitTest. Can you please try rebasing?

@veyndan
Copy link
Contributor Author
veyndan commented Sep 11, 2023

Rebased!

@veyndan veyndan deleted the paging-testing branch September 11, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ianhanniballake ianhanniballake ianhanniballake approved these changes

@claraf3 claraf3 claraf3 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@veyndan @dlam @claraf3 @ianhanniballake
0