8000 esp32s2: don't delete the event loop by jepler · Pull Request #3716 · adafruit/circuitpython · GitHub
[go: up one dir, main page]
Skip to content

esp32s2: don't delete the event loop#3716

Merged
tannewt merged 2 commits intoadafruit:mainfrom
jepler:keep-event-loop
Nov 19, 2020
Merged

esp32s2: don't delete the event loop#3716
tannewt merged 2 commits intoadafruit:mainfrom
jepler:keep-event-loop

Conversation

@jepler
Copy link
@jepler jepler commented Nov 18, 2020

.. it seems to make the esp-idf grumpy.

@jepler
esp32s2: don't delete the event loop
83d790a 
.. it seems to make the esp-idf grumpy.
@jepler
Copy link
Author
jepler commented Nov 18, 2020

This was to avoid an error in debug builds but the cure is worse than the disease.

esp_err_t esp_event_loop_create_default(void)
{
    if (s_default_loop) {
        return ESP_ERR_INVALID_STATE;
    }

@tannewt
Copy link
Member
tannewt commented Nov 18, 2020

How about tracking if netif has been started once and only get the loop when it hasn't been?

@jepler jepler requested a review from tannewt November 19, 2020 02:47
@jepler jepler mentioned this pull request Nov 19, 2020
Closed
@jepler
esp32s2: initialize event loop ane netif only once
dd108b7 
deinitting these seems to cause problems.
tannewt
tannewt approved these changes Nov 19, 2020
View reviewed changes
Copy link
Member
@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

This was referenced Nov 19, 2020
Closed
Closed
@tannewt tannewt merged commit 2f14609 into adafruit:main Nov 19, 2020
@jepler jepler deleted the keep-event-loop branch November 3, 2021 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tannewt tannewt tannewt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jepler @tannewt
0