8000 esp32-s2 gamepad.get_pressed() stuck on 0 after restart · Issue #3693 · adafruit/circuitpython · GitHub
[go: up one dir, main page]
Skip to content
8000

esp32-s2 gamepad.get_pressed() stuck on 0 after restart #3693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
FoamyGuy opened this issue Nov 15, 2020 · 3 comments
Closed

esp32-s2 gamepad.get_pressed() stuck on 0 after restart #3693

FoamyGuy opened this issue Nov 15, 2020 · 3 comments
Labels
bug espressif applies to multiple Espressif chips
Milestone
7.0.0

Comments

@FoamyGuy
Copy link
Collaborator

Using this script:

import time
import board
from digitalio import DigitalInOut, Direction, Pull
from gamepad import GamePad

print("wait before anything")
time.sleep(5)

btn_a = DigitalInOut(board.BUTTON_A)
btn_b = DigitalInOut(board.BUTTON_B)

# um feather s2 with OLED featherwing
# btn_a = DigitalInOut(board.IO33)
# btn_b = DigitalInOut(board.IO38)

_buttons = GamePad(
    btn_a,
    btn_b,
)
while True:
    print("{} - {}".format(btn_a.value, btn_b.value))
    print(_buttons.get_pressed())
    time.sleep(1)

When I run this on a ESP32-S2 (MagTag and UM Feather S2) directly after it boots up the printouts are as expected. The True and False values print correctly, as well as the numbers from _buttons.get_pressed() have the correct value.

But if I restart this script by using ctrl-c then ctrl-d the values from _buttons.get_pressed() will start to always show 0. The values from btn_a.value and btn_b.value still correctly change from True to False when I press buttons. But the gamepad values seem to get stuck on 0 after restarting this way.

The same code run on a CLUE and prints correct values both before and after restarting with ctrl-c / ctrl-d.
@FoamyGuy FoamyGuy added bug espressif applies to multiple Espressif chips labels Nov 15, 2020
@FoamyGuy FoamyGuy mentioned this issue Nov 15, 2020
Merged
@tannewt tannewt added this to the 6.x.x - Bug Fixes milestone Nov 16, 2020
@jepler
Copy link
jepler commented Nov 19, 2020

I had thought maybe the tick disable problem in #3710 could have fixed/improved this. However, now this seems to be resetting the magtag each time I reload the test program. Not good. I did my testing with the artifact from #3718 which doesn't have the fix from #3716 which is causing general instability so maybe not a good test.

@deshipu deshipu mentioned this issue Feb 27, 2021
Closed
@deshipu
Copy link
deshipu commented Feb 28, 2021

This could be somehow related to the long-lived object handling. The gampead singleton is created as a long-lived object, maybe it's not getting reset properly? I can't see anything immediately obvious in the code, though.

@dhalbert dhalbert modified the milestones: 6.x.x - Bug Fixes, 7.0.0 Mar 31, 2021
@tannewt
Copy link
Member
tannewt commented Jul 15, 2021

Superseded by keypad.

@tannewt tannewt closed this as completed Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug espressif applies to multiple Espressif chips
Projects
None yet
Milestone
7.0.0
Development

No branches or pull requests
5 participants
@tannewt @deshipu @jepler @FoamyGuy @dhalbert
0