8000 Add Metro ESP32S2 by tannewt · Pull Request #3495 · adafruit/circuitpython · GitHub
[go: up one dir, main page]
Skip to content

Add Metro ESP32S2 #3495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service 8000 and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 1, 2020
Merged

Add Metro ESP32S2 #3495

merged 2 commits into from
Oct 1, 2020

Conversation

tannewt
Copy link
Member
@tannewt tannewt commented Sep 30, 2020

Also fix two bugs:

@tannewt
Add Metro ESP32S2
a739d31 
Also fix two bugs:
* Crash when resetting board.SPI when it hasn't been inited.
* Reading back the output value is always false. Fixes micropython#3353
@ta 8000 nnewt
Add to board list
a6cfa50
@tannewt tannewt requested a review from ladyada September 30, 2020 20:00
ladyada
ladyada approved these changes Sep 30, 2020
View reviewed changes
Copy link
Member
@ladyada ladyada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

metro tested for sure! did not test other parts of PR

@tannewt tannewt merged commit f303fb3 into adafruit:main Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ladyada ladyada ladyada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reading the value of an output pin behaves differently in ESP32S2 than in SAMD
2 participants
@tannewt @ladyada
0