README: Add explicit section on contributing. #3353
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To increase visibility of Contributors' Guidelines and Code Conventions docs.
|
It seems that a lot of people miss to click that yellow-background link when submitting a pull request, so let's make contributing docs more visible. |
dpgeorge
reviewed
Oct 9, 2017
| productive, please be sure to follow | ||
| [Contributors' Guidelines](https://github.com/micropython/micropython/wiki/ContributorGuidelines) | ||
| and [Code Conventions](https://github.com/micropython/micropython/blob/master/CODECONVENTIONS.md) | ||
| 8000 docs. Note that MicroPython is licenced under the MIT license, and all |
There was a problem hiding this comment.
Needs a few articles: "... follow the [Contributor's Guidelines] and the [Code Conventions]."
Also doesn't need the word "docs" because "Guidelines" and "Conventions" are already the noun.
Yeah, makes sense to do something, and browsing thru github projects, many have such a short section in their READMEs, so maybe they find that useful. |
|
Merged. |
tannewt
added a commit
to tannewt/circuitpython
that referenced
this pull request
Sep 30, 2020
Also fix two bugs: * Crash when resetting board.SPI when it hasn't been inited. * Reading back the output value is always false. Fixes micropython#3353
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To increase visibility of Contributors' Guidelines and Code Conventions
docs.