-
Notifications
You must be signed in to change notification settings - Fork 1.3k
extend visibility of nibble_to_hex_upper and nibble_to_hex_lower #3188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The errors I've been getting on a Fedora 32 while compiling mpy-cross are:
My compiler version is:
|
Could it be this patch is unnecessary through the quest of solving this issue #3179? |
Ya, I think so. Can you just always add extern? That's what I did with my gcc10 changes. https://github.com/tannewt/circuitpython/tree/gcc10 |
Normally, you would make the declaration site be
and in the one source file which defines them,
By doing this, the somewhat magic preprocessor macro EXTERN is not required. |
This fixes the error of multiple definition that I've been finding during linking process.