8000 Prep for GCC10 by tannewt · Pull Request #3194 · adafruit/circuitpython · GitHub
[go: up one dir, main page]
Skip to content

Prep for GCC10 #3194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you a 8000 ccount related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 23, 2020
Merged

Prep for GCC10 #3194

merged 2 commits into from
Jul 23, 2020

Conversation

tannewt
Copy link
Member
@tannewt tannewt commented Jul 23, 2020

Add lots of missing extern and bring in Damien's fix.

tannewt and others added 2 commits July 22, 2020 16:26
@tannewt
Add externs. GCC10 complains about duplicate defines
2bd6d05
@dpgeorge @tannewt
py/py.mk: Use additional CFLAGS to compile string0.c.
f43834a 
Otherwise functions like memset might get optimised to call themselves (eg
with gcc 10).  And provide CFLAGS_BUILTIN so these options can be changed
by a port if needed.

Fixes issue micropython#6053.
@tannewt tannewt requested a review from dhalbert July 23, 2020 20:16
dhalbert
dhalbert approved these changes Jul 23, 2020
View reviewed changes
Copy link
Collaborator
@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine! Thanks for doing this earlier rather than later!

@dhalbert
Copy link
Collaborator

Two jobs are stuck. I think you could just merge.

@tannewt tannewt merged commit 060ab8a into adafruit:main Jul 23, 2020
@tvieira tvieira mentioned this pull request Jul 24, 2020
Closed
@jepler jepler mentioned this pull request Jul 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
bug tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tannewt @dhalbert @dpgeorge
0