8000 Fix Mac crash when waking up with an ejected CIRCUITPY by tannewt · Pull Request #2653 · adafruit/circuitpython · GitHub
[go: up one dir, main page]
Skip to content

Fix Mac crash when waking up with an ejected CIRCUITPY #2653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2020
Merged

Fix Mac crash when waking up with an ejected CIRCUITPY #2653

merged 1 commit into from
Feb 25, 2020

Conversation

tannewt
Copy link
Member
@tannewt tannewt commented Feb 24, 2020

We now correctly set the reason for the unit not being ready and
always start the unit.

Fixes #2567

@tannewt
Fix Mac crash when waking up with an ejected CIRCUITPY
876c646 
We now correctly set the reason for the unit not being ready and
always start the unit.

Fixes micropython#2567
@tannewt tannewt added this to the 5.0.0 milestone Feb 24, 2020
@tannewt tannewt requested review from hathach and dhalbert February 24, 2020 23:46
dhalbert
dhalbert approved these changes Feb 25, 2020
View reviewed changes
Copy link
Collaborator
@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, though the test and mpy-cross subjobs are crashing. I re-ran the actions, but the same thing happened. Merge as you wish.

hathach
hathach approved these changes Feb 25, 2020
View reviewed changes
Copy link
Member
@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

macOS is so persistent to get the sense code, look perfect :D

@tannewt tannewt merged commit 7037ebe into adafruit:master Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hathach hathach hathach approved these changes

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
bug crash usb
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

Leaving CIRCUITPY plugged into Mac when it sleeps crashes the Mac
3 participants
@tannewt @hathach @dhalbert
0