tests/extmod/uhashlib: Coverage for SHA1. #2567
Conversation
|
There is a separate sha256.py that I just didn't notice. Can we rename it to uhashlib_sha256.py and add a separate uhashlib_sha1.py? |
|
You don't need .exp files because these tests also run under CPython. |
|
My oversight, removed .exp! |
Can you please expand on this... how is SHA256 tested by tests/basics/builtin_hash.py? |
This is incorrect, I have mistakenly though that builtin_hash.py calls functions from moduhashlib. I didn't notice extmod/sha256.py and made an assumption that builtin_hash uses uhashlib, which is obviously incorrect and comes down to my lack of knowledge of how python works internally :) |
Ok, no problem. Then please edit the commit message to reflect this. Also, please make the rename of sha256.py a separate commit. Thanks! |
|
All done, thanks Damien! |
|
Merged, thanks! |
We now correctly set the reason for the unit not being ready and always start the unit. Fixes micropython#2567
Although SHA256 is tested as a part of builtin_hash test, there was no separate moduhashlib test. This also tests SHA1 algo for supported ports.