8000 Renamed wiznet5k_wsgiserver_test.py to wiznet5k_wsgiservertest.py by BiffoBear · Pull Request #76 · adafruit/Adafruit_CircuitPython_Wiznet5k · GitHub
[go: up one dir, main page]

Skip to content

Renamed wiznet5k_wsgiserver_test.py to wiznet5k_wsgiservertest.py #76

New issue

Have a question about this project? Sign up for 8000 a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 16, 2022
Merged

Renamed wiznet5k_wsgiserver_test.py to wiznet5k_wsgiservertest.py #76

merged 2 commits into from
Dec 16, 2022

Conversation

BiffoBear
Copy link
Contributor

Renamed wiznet5k_wsgiserver_test.py to wiznet5k_wsgiservertest.py to avoid problems with Pytest collecting tests. This will make future changes supported by unit tests simpler to implement.

…avoid problems with Pytest collecting tests.
Copy link
Member
@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind removing the _test portion completely? I don't think its needed in the filename at all. Thanks!

@BiffoBear
Copy link
Contributor Author
BiffoBear commented Dec 15, 2022

@tannewt Good idea, thank you. The file was renamed as requested.

@BiffoBear BiffoBear requested a review from tannewt December 16, 2022 02:41
Copy link
Member
@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tannewt tannewt merged commit 2d7a38e into adafruit:main Dec 16, 2022
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Dec 20, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_LC709203F to 2.2.10 from 2.2.9:
  > Merge pull request adafruit/Adafruit_CircuitPython_LC709203F#21 from dhalbert/esp32-s3-retries
  > Add .venv to .gitignore

Updating https://github.com/adafruit/Adafruit_CircuitPython_TLC59711 to 2.0.9 from 2.0.8:
  > Merge pull request adafruit/Adafruit_CircuitPython_TLC59711#22 from tcfranks/main
  > Add .venv to .gitignore
  > Update .pylintrc for v2.15.5
  > Fix release CI files
  > Update pylint to 2.15.5
  > Updated pylint version to 2.13.0
  > Switching to composite actions

Updating https://github.com/adafruit/Adafruit_CircuitPython_Wiznet5k to 1.12.17 from 1.12.16:
  > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#76 from BiffoBear/Rename_example_to_prevent_clash_with_pytest

Updating https://github.com/adafruit/Adafruit_CircuitPython_framebuf to 1.5.0 from 1.4.14:
  > Merge pull request adafruit/Adafruit_CircuitPython_framebuf#48 from philsuth/rgb565
  > Add .venv to .gitignore
  > Update .pylintrc for v2.15.5
  > Fix release CI files
  > Update pylint to 2.15.5
  > Updated pylint version to 2.13.0
  > Switching to composite actions

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0